Skip to content

[Common] Uniform tracks extra converter to the coding conventions #3671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ddobrigk merged 2 commits into from
Oct 24, 2023
Merged

[Common] Uniform tracks extra converter to the coding conventions #3671

ddobrigk merged 2 commits into from
Oct 24, 2023

Conversation

@fmazzasc
Copy link
Collaborator

@fmazzasc fmazzasc commented Oct 22, 2023

vkucera
vkucera requested changes Oct 22, 2023
View reviewed changes
Copy link
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fmazzasc , please also fix the capitalisation of task (struct) names and add the Doxygen documentation.

@fmazzasc
Copy link
Collaborator Author

fmazzasc commented Oct 23, 2023

@vkucera , is it fine now?

@alibuild
Copy link
Collaborator

alibuild commented Oct 23, 2023

Error while checking build/O2Physics/o2 for 1f0a30f at 2023-10-23 12:00:

No log files found

Full log here.

@vkucera
Copy link
Collaborator

vkucera commented Oct 23, 2023

@vkucera , is it fine now?

Yes, perfect! Thanks a lot!

@fmazzasc fmazzasc mentioned this pull request Oct 23, 2023
Merged
@fmazzasc
Copy link
Collaborator Author

fmazzasc commented Oct 23, 2023 •
edited
Loading

C.I. is apparently failing for unrelated issues. Could we merge this p.r. anyway?

@ddobrigk ddobrigk merged commit aadd301 into AliceO2Group:master Oct 24, 2023
@ddobrigk
Copy link
Collaborator

ddobrigk commented Oct 24, 2023

C.I. is apparently failing for unrelated issues. Could we merge this p.r. anyway?

Thanks!! Done! @fmazzasc I will try and keep an eye on the change to 001 and once that's merged then I can take care of creating the core service on hyperloop for the converter.

zconesa pushed a commit to zconesa/O2Physics that referenced this pull request Oct 27, 2023
@fmazzasc @zconesa
[Common] Uniform tracks extra converter to the coding conventions (Al…
6b4d309 
…iceO2Group#3671)

* [Common] Uniform tracks extra converter to the coding conventions

* Add doxygen documentation + capitalize tasks
chengtt0406 pushed a commit to chengtt0406/O2Physics that referenced this pull request Dec 6, 2023
@fmazzasc @chengtt0406
[Common] Uniform tracks extra converter to the coding conventions (Al…
4adc8af 
…iceO2Group#3671)

* [Common] Uniform tracks extra converter to the coding conventions

* Add doxygen documentation + capitalize tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera approved these changes

@ddobrigk ddobrigk ddobrigk approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner

@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner

@ktf ktf Awaiting requested review from ktf ktf is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fmazzasc @alibuild @vkucera @ddobrigk