Move to expression columns for most used columns#3829
Merged
njacazio merged 4 commits intoAliceO2Group:masterfrom Nov 11, 2023
Merged
Move to expression columns for most used columns#3829njacazio merged 4 commits intoAliceO2Group:masterfrom
njacazio merged 4 commits intoAliceO2Group:masterfrom
Conversation
ddobrigk
requested review from
BongHwi,
ChiaraDeMartin95,
alibuild,
chiarapinto,
iravasen,
lbariogl,
lramona,
mbombara,
njacazio and
skundu692
as code owners
njacazio
previously approved these changes
Nov 11, 2023
Collaborator
|
Ah the ci is failing |
njacazio
approved these changes
Nov 11, 2023
chengtt0406
pushed a commit
to chengtt0406/O2Physics
that referenced
this pull request
Dec 6, 2023
* Move common stuff to expression columns * Cleanup * Please consider the following formatting changes (AliceO2Group#182) --------- Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch> Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the most commonly used variables to expression columns in the strangeness model. As next few steps, the CosPAs will be changed into regular columns, so they can be filtered on, and indices and other variables will be further separated into sub-tables that are joinable.
Combined with the already modular strangeness PID tables and some further adjustments, one of the goals here is that, should the need arise, the intermediate format from the builders could already serve as derived data.