PWGHF: cleaning toXiPi tasks#3839
Merged
mfaggin merged 19 commits intoAliceO2Group:masterfrom Nov 14, 2023
Merged
Conversation
Contributor
ZFederica
commented
Nov 13, 2023
- unify naming scheme for xic and omegac
- add decay length and corresponding error to table
- remove unnecessary elements from tables
- remove unnecessary variable/calculation/propagation in tasks
- remove unnecessary event table from treeCreator
Please consider the following formatting changes to AliceO2Group#3839
Collaborator
|
Error while checking build/O2Physics/o2 for 8b6dba7 at 2023-11-13 12:30: Full log here. |
Collaborator
|
Error while checking build/O2Physics/o2 for 4c0a70f at 2023-11-13 12:40: Full log here. |
Please consider the following formatting changes to AliceO2Group#3839
Collaborator
|
Error while checking build/O2Physics/o2 for 33ecf57 at 2023-11-13 12:56: Full log here. |
mfaggin
reviewed
Nov 13, 2023
mfaggin
reviewed
Nov 13, 2023
mfaggin
reviewed
Nov 13, 2023
mfaggin
reviewed
Nov 13, 2023
mfaggin
reviewed
Nov 13, 2023
mfaggin
reviewed
Nov 13, 2023
mfaggin
reviewed
Nov 13, 2023
mfaggin
requested changes
Nov 13, 2023
Collaborator
There was a problem hiding this comment.
thanks @ZFederica . I have only minor comments from the point of view of variable names.
Best.
Mattia
Co-authored-by: Mattia Faggin <mattia.faggin@cern.ch>
Co-authored-by: Mattia Faggin <mattia.faggin@cern.ch>
Co-authored-by: Mattia Faggin <mattia.faggin@cern.ch>
Co-authored-by: Mattia Faggin <mattia.faggin@cern.ch>
Collaborator
|
Error while checking build/O2Physics/o2 for 05bff1e at 2023-11-14 10:01: Full log here. |
Collaborator
|
Error while checking build/O2Physics/o2 for 3e73e36 at 2023-11-14 10:22: Full log here. |
Please consider the following formatting changes to AliceO2Group#3839
Contributor
Author
|
Hi @mfaggin, now all the variable names comply to your requirement |
mfaggin
approved these changes
Nov 14, 2023
Collaborator
mfaggin
left a comment
There was a problem hiding this comment.
sorry for the late reply @ZFederica , ok for me!
chengtt0406
pushed a commit
to chengtt0406/O2Physics
that referenced
this pull request
Dec 6, 2023
* Update * Decay length * Clean tables * Please consider the following formatting changes * Temp * Solve errors * Please consider the following formatting changes * Remove table * Fix typo * Update PWGHF/DataModel/CandidateReconstructionTables.h Co-authored-by: Mattia Faggin <mattia.faggin@cern.ch> * Update PWGHF/DataModel/CandidateSelectionTables.h Co-authored-by: Mattia Faggin <mattia.faggin@cern.ch> * Update PWGHF/TableProducer/candidateSelectorToXiPi.cxx Co-authored-by: Mattia Faggin <mattia.faggin@cern.ch> * Update PWGHF/TableProducer/treeCreatorToXiPi.cxx Co-authored-by: Mattia Faggin <mattia.faggin@cern.ch> * Change names to charm baryon * Please consider the following formatting changes --------- Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Mattia Faggin <mattia.faggin@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.