Update of Phi In/Out of jets#4624
Merged
nzardosh merged 15 commits intoAliceO2Group:masterfrom Feb 13, 2024
Merged
Conversation
smaff92
requested review from
alibuild,
ddobrigk,
maoyx,
mfasDa and
nzardosh
as code owners
[MegaLinter] Apply linters automatic fixes to AliceO2Group#4624
Please consider the following formatting changes to AliceO2Group#4624
Collaborator
|
Error while checking build/O2Physics/o2 for b055c3e at 2024-02-07 10:18: Full log here. |
Collaborator
|
Error while checking build/O2Physics/o2 for 6b92dbd at 2024-02-07 10:24: Full log here. |
[MegaLinter] Apply linters automatic fixes to AliceO2Group#4624
Please consider the following formatting changes to AliceO2Group#4624
nzardosh
approved these changes
Feb 13, 2024
|
|
||
| int nEvents = 0; | ||
| void processJetTracks(JetCollision const& collision, soa::Filtered<aod::ChargedJets> const& chargedjets, soa::Join<JetTracks, aod::JTrackPIs> const& tracks, TrackCandidates const&) | ||
| void processJetTracks(aod::JCollision const& collision, soa::Filtered<soa::Join<aod::ChargedJets, aod::ChargedJetConstituents>> const& chargedjets, soa::Join<aod::JTracks, aod::JTrackPIs> const& tracks, TrackCandidates const&) |
Collaborator
There was a problem hiding this comment.
please use the keywords like JetCollisions and JetTracks where possible. you can find these at the end of DataModel/Jet.h
basiach
pushed a commit
to basiach/O2Physics
that referenced
this pull request
Feb 23, 2024
* Extensive overhauls of code, now added MC functionality * Please consider the following formatting changes * MegaLinter fixes * Quick bugfix * Please consider the following formatting changes * MegaLinter fixes --------- Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extensive update, now adding MC functionality