Merged
Conversation
daveryan99
requested review from
alibuild,
feisenhu,
mikesas and
rbailhac
as code owners
mikesas
approved these changes
Feb 15, 2024
basiach
pushed a commit
to basiach/O2Physics
that referenced
this pull request
Feb 23, 2024
* Update PWGEM/Tasks * Correct phosAlign.cxx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected a few bugs from the previous commit connected with wrong type conversions (bc_as<>, collision_as<>) and incorrect histogram filling (getting timestamp and SOR in wrong places). Also added new file for PHOS alignment check.