adding new task to CF/EbyE #4959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altsybee
requested review from
alibuild,
jgrosseo,
saganatt,
victor-gonzalez and
zchochul
as code owners
Please consider the following formatting changes to AliceO2Group#4959
Please consider the following formatting changes to AliceO2Group#4959
Comment on lines
+89
to
+99
| OutputObj<TH1D> h2D_Orbit_vs_CollIndex_0{TH1D("h2D_Orbit_vs_CollIndex_DF0", "h2D_Orbit_vs_CollIndex_DF0;collision index;orbit", 10001, -0.5, 10000.5)}; | ||
| OutputObj<TH1D> h2D_Orbit_vs_CollIndex_1{TH1D("h2D_Orbit_vs_CollIndex_DF1", "h2D_Orbit_vs_CollIndex_DF1;collision index;orbit", 10001, -0.5, 10000.5)}; | ||
| OutputObj<TH1D> h2D_Orbit_vs_CollIndex_2{TH1D("h2D_Orbit_vs_CollIndex_DF2", "h2D_Orbit_vs_CollIndex_DF2;collision index;orbit", 10001, -0.5, 10000.5)}; | ||
| OutputObj<TH1D> h2D_Orbit_vs_CollIndex_3{TH1D("h2D_Orbit_vs_CollIndex_DF3", "h2D_Orbit_vs_CollIndex_DF3;collision index;orbit", 10001, -0.5, 10000.5)}; | ||
| OutputObj<TH1D> h2D_Orbit_vs_CollIndex_4{TH1D("h2D_Orbit_vs_CollIndex_DF4", "h2D_Orbit_vs_CollIndex_DF4;collision index;orbit", 10001, -0.5, 10000.5)}; | ||
|
|
||
| OutputObj<TH1D> h2D_BC_vs_CollIndex_0{TH1D("h2D_BC_vs_CollIndex_DF0", "h2D_BC_vs_CollIndex_DF0;collision index;orbit", 10001, -0.5, 10000.5)}; | ||
| OutputObj<TH1D> h2D_BC_vs_CollIndex_1{TH1D("h2D_BC_vs_CollIndex_DF1", "h2D_BC_vs_CollIndex_DF1;collision index;orbit", 10001, -0.5, 10000.5)}; | ||
| OutputObj<TH1D> h2D_BC_vs_CollIndex_2{TH1D("h2D_BC_vs_CollIndex_DF2", "h2D_BC_vs_CollIndex_DF2;collision index;orbit", 10001, -0.5, 10000.5)}; | ||
| OutputObj<TH1D> h2D_BC_vs_CollIndex_3{TH1D("h2D_BC_vs_CollIndex_DF3", "h2D_BC_vs_CollIndex_DF3;collision index;orbit", 10001, -0.5, 10000.5)}; | ||
| OutputObj<TH1D> h2D_BC_vs_CollIndex_4{TH1D("h2D_BC_vs_CollIndex_DF4", "h2D_BC_vs_CollIndex_DF4;collision index;orbit", 10001, -0.5, 10000.5)}; |
Collaborator
There was a problem hiding this comment.
Any reason for not having them in one HistogramRegistry?
Comment on lines
+117
to
+118
| // AxisSpec axisNcontrib{flagPbPb ? 8001 : 501, -0.5, flagPbPb ? 8000.5 : 500.5, "n vertex contributors"}; | ||
| // AxisSpec axisNtracks{flagPbPb ? 8001 : 501, -0.5, flagPbPb ? 8000.5 : 500.5, "n tracks"}; |
Collaborator
There was a problem hiding this comment.
Please, as an overall rule in O2, don't leave code commented
It is confusing if someone wants to learn on what you have done
I saw in some cases you comment a section of code apparently for preserving it either for your knowledge or to latter use. In gitHub, you know, there is a right place for doing that: gitHub gists, https://gist.github.com/altsybee
Comment on lines
+736
to
+751
| // Defining filters for events (event selection) | ||
| // Processed events will be already fulfilling the event selection requirements | ||
| // Filter eventFilter = (o2::aod::evsel::sel8 == true); | ||
| // Filter posZFilter = (nabs(o2::aod::collision::posZ) < cutzvertex); | ||
|
|
||
| // Filter<aod::Tracks> ptFilter = aod::track::pt > 1; | ||
|
|
||
| // void process(aod::TracksIU const& tracks) | ||
| // void process(aod::Collision const& collision, aod::Tracks &tracks) { | ||
| // void process(aod::Collision const& collision, soa::Filtered<aod::Tracks> &tracks) { | ||
| // void process(aod::Collision const& collision, soa::Join<aod::Tracks, aod::TracksExtra, aod::TracksDCA> const& tracks) | ||
| // void process(aod::Collision const& collision, aod::fullTrack const& fullTrack) // one can use the abbreviation FullTrack, which is a predefined join of all three track tables | ||
| // A list of predefined joins is available in The Data Model section of these documentation pages). | ||
|
|
||
| // The grouping works with any number of children. In the below example the process function is given three arguments. In this case process is run for each collision with the tracks and V0s belonging to the actual collision. | ||
| // void process(aod::Collision const& collision, aod::Tracks const& tracks, aod::V0s const& v0s) |
Collaborator
There was a problem hiding this comment.
Commenting code (what the code does) is correct but leaving code commented is against our rules
victor-gonzalez
approved these changes
Mar 2, 2024
Collaborator
victor-gonzalez
left a comment
victor-gonzalez
left a comment
There was a problem hiding this comment.
I approve it for the time being but for the next iteration please consider my comments, specially the one referring to remove all commented code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new task to CF/EbyE - "RobustFluctuationObservables" (so far, with QA plots)