PWGCF: dEdx plots for IdentifedBF#5792
Merged
victor-gonzalez merged 68 commits intoAliceO2Group:masterfrom Apr 23, 2024
Merged
Conversation
Please consider the following formatting changes to AliceO2Group#4619
Please consider the following formatting changes to AliceO2Group#4619
Please consider the following formatting changes to AliceO2Group#4619
… Fixed issue where species and charge were considered separately
Please consider the following formatting changes to AliceO2Group#4840
bghanley1995
requested review from
alibuild,
saganatt,
victor-gonzalez and
zchochul
as code owners
Please consider the following formatting changes to AliceO2Group#5792
victor-gonzalez
approved these changes
Apr 22, 2024
Collaborator
|
Brian, you have to locally rebase your changes to the latest version of O2 Physics |
Collaborator
|
I will approve it for the time being but next time you push your new PR with your local repo updated to the latest version (well, almost the latest) this one was almost from two months ago! |
Contributor
Author
|
Thank you Victor, I thought I'd updated it properly. I'll make extra sure going forward |
Collaborator
|
Well, if you look at this PR up, above these comments, you see that there are commits since two months most of them are probably not from you. |
christianreckziegel
pushed a commit
to christianreckziegel/O2Physics
that referenced
this pull request
May 2, 2024
* Adding functionality for Identified two particle correlations and balance functions * Reuploading code for Identified Balance Functions * Fixed white space formatting error in CMakeLists.txt * Please consider the following formatting changes * Fixed Linter errors * Please consider the following formatting changes * Fixed additional linter errors * Please consider the following formatting changes * Fixed linter include linter error * Fixed linter error where I wrote DataModel instead of TableProducer in header * Adding PID values for particle species, not just charge * Further updates to Identified Balance Function code to implement PID. Fixed issue where species and charge were considered separately * Fixed Build Errors * Please consider the following formatting changes * removed whitespace * Fixed Linter error * Please consider the following formatting changes * Fixed static_cast<int>(...) error from build * removed commented out code * removed MORE commented out code * Please consider the following formatting changes * Made the minimum sigma value for PID a configurable value for testing * Adding statements for debugging. Remove before requesting merge * Fixed error where there were not enough track names for the number of tracks causing a Segmentation Fault * Finding error where particle centrality is always rejected * Troubleshooting PID processes, all commented code and extraneous outputs removed * Removed fhParticleSpecies which was leftover from testing * Added dE/dx vs p plots; changed naming conventions for particle pairs * Updated a bad call to a track table * Please consider the following formatting changes --------- Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
hahassan7
pushed a commit
to hahassan7/O2Physics
that referenced
this pull request
May 17, 2024
* Adding functionality for Identified two particle correlations and balance functions * Reuploading code for Identified Balance Functions * Fixed white space formatting error in CMakeLists.txt * Please consider the following formatting changes * Fixed Linter errors * Please consider the following formatting changes * Fixed additional linter errors * Please consider the following formatting changes * Fixed linter include linter error * Fixed linter error where I wrote DataModel instead of TableProducer in header * Adding PID values for particle species, not just charge * Further updates to Identified Balance Function code to implement PID. Fixed issue where species and charge were considered separately * Fixed Build Errors * Please consider the following formatting changes * removed whitespace * Fixed Linter error * Please consider the following formatting changes * Fixed static_cast<int>(...) error from build * removed commented out code * removed MORE commented out code * Please consider the following formatting changes * Made the minimum sigma value for PID a configurable value for testing * Adding statements for debugging. Remove before requesting merge * Fixed error where there were not enough track names for the number of tracks causing a Segmentation Fault * Finding error where particle centrality is always rejected * Troubleshooting PID processes, all commented code and extraneous outputs removed * Removed fhParticleSpecies which was leftover from testing * Added dE/dx vs p plots; changed naming conventions for particle pairs * Updated a bad call to a track table * Please consider the following formatting changes --------- Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.