PWGEM/PhotonMeson: Fix wrong dimension when filling rotation histograms#6791
Merged
mhemmer-cern merged 3 commits intoAliceO2Group:masterfrom Jul 9, 2024
Merged
PWGEM/PhotonMeson: Fix wrong dimension when filling rotation histograms#6791mhemmer-cern merged 3 commits intoAliceO2Group:masterfrom
mhemmer-cern merged 3 commits intoAliceO2Group:masterfrom
Conversation
Collaborator
nstrangm
commented
Jul 9, 2024
nstrangm
commented
- Yesterdays PR removed two dimensions from the minv-pt histogram, but two zeros were still included in the filling of the rotation histogram, leading to Hyperloop tests to fail
- Removed the additional fill arguments, this should fix the issue
- Yesterdays PR removed two dimensions from the minv-pt histogram, but two zeros were still included in the filling of the rotation histogram, leading to Hyperloop tests to fail - Removed the additional fill arguments, this should fix the issue
nstrangm
requested review from
alibuild,
dsekihat,
m-c-danisch,
mhemmer-cern,
mikesas,
novitzky and
rbailhac
as code owners
Please consider the following formatting changes to AliceO2Group#6791
mhemmer-cern
approved these changes
Jul 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.