-
Notifications
You must be signed in to change notification settings - Fork 622
PWGHF: change track table for LF daughters #7332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please consider the following formatting changes to AliceO2Group#7332
|
Error while checking build/O2Physics/o2 for edaf445 at 2024-08-16 18:05: Full log here. |
|
Error while checking build/O2Physics/o2 for 8734d6f at 2024-08-16 18:09: Full log here. |
mfaggin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ciao Federica,
I have one major comment (easy to be solved). Try to cross check once more if the issue that I highlight is somewhere else in your code (I have not found it anywhere else, I hope not to have skipped any)
| auto trackCascDauCharged = casc.bachelor_as<MyLFTracksWCov>(); // pion <- xi track | ||
| auto trackV0Dau0 = casc.posTrack_as<MyLFTracksWCov>(); // V0 positive daughter track | ||
| auto trackV0Dau1 = casc.negTrack_as<MyLFTracksWCov>(); // V0 negative daughter track | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Casting your tracks to MyLFTracksWCov, then your pseudorapV0Dau0, pseudorapV0Dau1 and pseudorapCascBachelor are taken from the IU point of the track. Viceversa, casting them to TracksWCovDca as you were doing before means that you take the eta values from the PV.
None of this is correct, since you need the eta of these tracks at the Xi vertex. You should probably use the getters from the LF data model (see here https://github.com/AliceO2Group/O2Physics/blob/master/PWGLF/DataModel/LFStrangenessTables.h#L1096-L1104)
Actually, for eta this should not create a big issue, but for pt it does so be careful. I do not see other places where this issue happens, but be sure not to take any variable of the daughter at the wrong vertex (i.e. for Xi duaghters use the methods from the LF data models, but it seems that you are using them correctly in the other places)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mfaggin! I think now it should be fine
|
Error while checking build/O2Physics/o2 for 1c792e9 at 2024-08-16 23:59: Full log here. |
Please consider the following formatting changes to AliceO2Group#7332
|
Error while checking build/O2Physics/o2 for 013ef36 at 2024-08-17 16:24: Full log here. |
Please consider the following formatting changes to AliceO2Group#7332
* Change track table for LF daughters * Remove unnecessary change * Please consider the following formatting changes * Fix build error * Retrieve eta at the correct vertex * Fix build error * Fix build error * Please consider the following formatting changes * Fix track table * Please consider the following formatting changes --------- Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
* Change track table for LF daughters * Remove unnecessary change * Please consider the following formatting changes * Fix build error * Retrieve eta at the correct vertex * Fix build error * Fix build error * Please consider the following formatting changes * Fix track table * Please consider the following formatting changes --------- Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Change table used to load information about cascade/V0 daughters (candidateCreator and candidateSelectors): Tracks -> TracksIU
@mfaggin