PWGHF: Add Bs meson to creator of reduced data model #7950
Merged
fcatalan92 merged 6 commits intoAliceO2Group:masterfrom Oct 11, 2024
Merged
PWGHF: Add Bs meson to creator of reduced data model #7950fcatalan92 merged 6 commits intoAliceO2Group:masterfrom
fcatalan92 merged 6 commits intoAliceO2Group:masterfrom
Conversation
fcatalan92
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcolamar,
fgrosa,
hahassan7,
jpxrk,
mfaggin,
mmazzilli and
vkucera
as code owners
fgrosa
requested changes
Oct 11, 2024
Collaborator
fgrosa
left a comment
fgrosa
left a comment
There was a problem hiding this comment.
Hi @fcatalan92, the PR looks good to me except for two minor comments (see below)
fgrosa
approved these changes
Oct 11, 2024
alibuild
approved these changes
Oct 11, 2024
Collaborator
alibuild
left a comment
alibuild
left a comment
There was a problem hiding this comment.
Auto-approving on behalf of @fcatalan92.
Contributor
|
Hi @fcatalan92, |
mfaggin
pushed a commit
to mfaggin/O2Physics
that referenced
this pull request
Oct 15, 2024
* Add Bs to reduced data model * clang format * Add Bs to creator of reduced data format * Use name for K0* PDG code * Adapt reduced data model to support Ds mass hypotheses * Rework inv mass histograms and add Ds mass hypotheses
louisemillot
pushed a commit
to louisemillot/O2Physics
that referenced
this pull request
Nov 26, 2024
* Add Bs to reduced data model * clang format * Add Bs to creator of reduced data format * Use name for K0* PDG code * Adapt reduced data model to support Ds mass hypotheses * Rework inv mass histograms and add Ds mass hypotheses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few things still need to be polished but it should work already.
@apalasciano, @fchinu, @AlexBigO, please check that this PR does not disrupt your workflows.