Skip to content

PWGHF: Add the QA plots for the mixed-event and Change the strategy of mixed event#8028

Merged
zhangbiao-phy merged 14 commits intoAliceO2Group:masterfrom
zhangbiao-phy:master
Oct 18, 2024
Merged

PWGHF: Add the QA plots for the mixed-event and Change the strategy of mixed event#8028
zhangbiao-phy merged 14 commits intoAliceO2Group:masterfrom
zhangbiao-phy:master

Conversation

@zhangbiao-phy
Copy link
Collaborator

@zhangbiao-phy zhangbiao-phy commented Oct 16, 2024

Hi @1994ra and @fgrosa, The commit I implemented last week is still not satisfactory, since the number of events that contain lc (with selection) in one DF are few. The mixed event flow can only process in one DF for the current O2. so I made further modifications. Now, the producer no longer stores only the Lc-proton pair for collisions. Instead, I’ve set a mask to tag the collisions that contain at least one Lc or at least one selected track. Let me know if you have any questions or comments. Thanks!

@zhangbiao-phy zhangbiao-phy changed the title Change the strategy of mixed event and add the QA plots for the mixed-event PWGHF: Add the QA plots for the mixed-event and Change the strategy of mixed event Oct 16, 2024
@zhangbiao-phy zhangbiao-phy marked this pull request as ready for review October 16, 2024 15:58
@zhangbiao-phy zhangbiao-phy marked this pull request as draft October 16, 2024 23:17
@fgrosa
Copy link
Collaborator

fgrosa commented Oct 17, 2024

Hi @zhangbiao-phy, thanks a lot!
I remember that we chose the strategy to save only events that contain a p-Lc pair to reduce the disk space. In case derived data are produced, DF are merged and therefore we should have enough protons and Lcs to pair.
Is this not the case because you are doing all in one go, without producing derived data?

zhangbiao-phy and others added 5 commits October 17, 2024 13:32
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
@zhangbiao-phy
Copy link
Collaborator Author

zhangbiao-phy commented Oct 17, 2024

Hi @zhangbiao-phy, thanks a lot! I remember that we chose the strategy to save only events that contain a p-Lc pair to reduce the disk space. In case derived data are produced, DF are merged and therefore we should have enough protons and Lcs to pair. Is this not the case because you are doing all in one go, without producing derived data?

Hi @fgrosa, yes, this is the previous strategy in the producer, but we don't save the derived table at this stage. So, from what I tested locally, I did not find it would increase the disk space a lot. Then I would say It's not merged in the task process, then the event pool is arround ~10-25, so it's hard to mix 10 events in that pool.

Another method is to save the collision index, vz, and mul in the final derived table, then mix it locally. These are the two methods also used in HFC currently.

Is this not the case because you are doing all in one go, without producing derived data?

ah, yes, I only produce the final table, for this, let me try again now. Thanks

@zhangbiao-phy
Copy link
Collaborator Author

Is this not the case because you are doing all in one go, without producing derived data?

It's not the case, the point is still the number of collisions that include Lc-p pair (satisfy the Lc selection) are very few.

@zhangbiao-phy zhangbiao-phy marked this pull request as ready for review October 17, 2024 13:18
@fgrosa
Copy link
Collaborator

fgrosa commented Oct 17, 2024

Hi @zhangbiao-phy thanks for the explanation, good for me!

Copy link
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zhangbiao-phy for implementing my suggestions.
I let @deepathoms @apalasciano have the final look and merge.

@zhangbiao-phy zhangbiao-phy enabled auto-merge (squash) October 17, 2024 22:40
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @zhangbiao-phy.

@zhangbiao-phy zhangbiao-phy merged commit 216a51a into AliceO2Group:master Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants