Skip to content

Conversation

@aalkin
Copy link
Member

@aalkin aalkin commented Nov 6, 2024

This is (hopefully) the last compatibility change in O2Physics to unblock updating of O2.

Important notes:

  • aod-data-model-graph is temporarily disabled, as it is impossible to make it compile with both versions of O2 - it uses a lot of internal functions. After O2 is update, I will move framework-specific back into O2, so that data model graph can use abstracted API instead of relying on internals
  • CEPF task reverted to use persistent_columns_t temporarily, same as with the data model graph I will move it to dedicated API that hides the framework internals
  • PWGCF/Femto3D: declaration of versioned tables using existing _VERSIONED macro
  • PWGDQ: the table description together with the table will become the primary distinctive feature of the table declaration, it will define the set of columns. Therefore different tables should have different descriptions. Additionally, the declarations are repeated 3 times in different tasks, consider moving them to a single header. Please also note that changed description also means you need to change the configuration of aod-writer if you want to store these tables.
  • PWGHF: declaration of versioned tables using existing _VERSIONED macro
  • PWGLF: declaration of staged/versioned tables using existing _VERSIONED macro; Spawns<> requires a table type, and not an iterator alias, it was functional essentially by accident.

@aalkin aalkin requested review from a team, ddobrigk, jgrosseo, ktf and lietava as code owners November 6, 2024 11:22
@github-actions github-actions bot changed the title DPL Analysis: more compatibility changes for the upcoming O2 update [Common,PWGCF,PWGDQ,PWGHF,PWGLF,Trigger] DPL Analysis: more compatibility changes for the upcoming O2 update Nov 6, 2024
@alibuild
Copy link
Collaborator

alibuild commented Nov 6, 2024

Error while checking build/O2Physics/o2 for 1b4ee87 at 2024-11-06 13:16:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/8322-slc7_x86-64/0/EventFiltering/filterTables.h:21:11: error: 'uint32_t' has not been declared
ninja: build stopped: subcommand failed.

Full log here.

@njacazio
Copy link
Collaborator

njacazio commented Nov 6, 2024

Thanks a lot Anton

Copy link
Collaborator

@ddobrigk ddobrigk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of common (small and uncontroversial)

@aalkin
Copy link
Member Author

aalkin commented Nov 7, 2024

The approvals for trigger, DQ and CF are still required.
@mpuccio, @iarsene, @saganatt could you please add your review?

Copy link
Collaborator

@victor-gonzalez victor-gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Anton!

@aalkin
Copy link
Member Author

aalkin commented Nov 12, 2024

An approval for DQ is still required.
@iarsene @dsekihat @feisenhu @lucamicheletti93 could you please take a look?

@vkucera vkucera merged commit 7ea31c3 into AliceO2Group:master Nov 12, 2024
christianreckziegel pushed a commit to christianreckziegel/O2Physics that referenced this pull request Nov 19, 2024
…lity changes for the upcoming O2 update (AliceO2Group#8322)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

8 participants