[PWGLF] Added a new workflow for the Xi(1530)0 analysis QA #8408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjkim525
requested review from
BongHwi,
alibuild,
njacazio,
skundu692 and
smaff92
as code owners
[PWGLF] Please consider the following formatting changes to AliceO2Group#8408
mjkim525
added a commit
to mjkim525/O2Physics
that referenced
this pull request
Nov 12, 2024
[PWGLF] Please consider the following formatting changes to AliceO2Group#8408
smaff92
approved these changes
Nov 13, 2024
Collaborator
smaff92
left a comment
smaff92
left a comment
There was a problem hiding this comment.
Will approve for now, but please for next time, remove all of the huge commented sections and save them in a separate backup.
BongHwi
approved these changes
Nov 13, 2024
vkucera
reviewed
Nov 13, 2024
Comment on lines
+781
to
+783
| lDecayDaughter1.SetPtEtaPhiM(trk1.pt(), trk1.eta(), trk1.phi(), massPi); | ||
| lDecayDaughter2.SetPtEtaPhiM(trk2.pt(), trk2.eta(), trk2.phi(), trk2.mXi()); | ||
| lResonance = lDecayDaughter1 + lDecayDaughter2; |
Collaborator
There was a problem hiding this comment.
Consider using RecoDecay methods with C++ arrays instead of unnecessarily heavy TLorentzVector objects.
vkucera
reviewed
Nov 13, 2024
| lDecayDaughter2.SetPtEtaPhiM(trk2.pt(), trk2.eta(), trk2.phi(), trk2.mXi()); | ||
| lResonance = lDecayDaughter1 + lDecayDaughter2; | ||
|
|
||
| if (abs(lResonance.Rapidity()) >= 0.5) |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (abs(lResonance.Rapidity()) >= 0.5) | |
| if (std::abs(lResonance.Rapidity()) >= 0.5) |
This is a bug. abs will truncate to int.
vkucera
reviewed
Nov 13, 2024
Comment on lines
+801
to
+806
| histos.fill(HIST("Xi1530invmassDS"), lResonance.M()); | ||
| histos.fill(HIST("h3Xi1530invmassDS"), multiplicity, lResonance.Pt(), lResonance.M(), kData); | ||
| } else if (trk1.sign() < 0) { | ||
| if (invmass1D) | ||
| histos.fill(HIST("Xi1530invmassDSAnti"), lResonance.M()); | ||
| histos.fill(HIST("h3Xi1530invmassDSAnti"), multiplicity, lResonance.Pt(), lResonance.M(), kData); |
Collaborator
There was a problem hiding this comment.
Store the results in variables instead of calling the same calculations repeatedly.
vkucera
reviewed
Nov 13, 2024
Comment on lines
+828
to
+834
| if constexpr (IsMC) { | ||
| if (abs(trk1.pdgCode()) != 211 || abs(trk2.pdgCode()) != 3312) | ||
| continue; | ||
| if (trk1.motherId() != trk2.motherId()) | ||
| continue; | ||
| if (abs(trk2.motherPDG()) != 3324) | ||
| continue; |
Collaborator
There was a problem hiding this comment.
Consider using named PDG codes.
vkucera
reviewed
Nov 13, 2024
Comment on lines
+898
to
+902
| for (auto& part : resoParents) { // loop over all pre-filtered MC particles | ||
| if (abs(part.pdgCode()) != 3324 || abs(part.y()) >= 0.5) | ||
| continue; | ||
| bool pass1 = abs(part.daughterPDG1()) == 211 || abs(part.daughterPDG2()) == 211; | ||
| bool pass2 = abs(part.daughterPDG1()) == 3312 || abs(part.daughterPDG2()) == 3312; |
Collaborator
There was a problem hiding this comment.
Same comments.
Use std::abs everywhere and you're safe.
Collaborator
|
Oops.. the PR is merged already. but I'm sure that we should update the task very soon with the PID information, which was commented this time. At that time, we can include the suggestions from @vkucera |
christianreckziegel
pushed a commit
to christianreckziegel/O2Physics
that referenced
this pull request
Nov 19, 2024
…oup#8408) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
feisenhu
pushed a commit
to feisenhu/O2Physics
that referenced
this pull request
Jan 8, 2025
…oup#8408) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone.
My name is Min-jae Kim and i have newly joined PAG resonance.
I have added a new workflow to compare it with the existing code for the Xi(1530)0 analysis.