[PWGJE] [PWGJE,EMCAL-670]Add offline time calibration for data in EMCalCorrectionTask #8513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nstrangm
commented
Nov 18, 2024
nstrangm
commented
- Add a cell time shift in EMCalCorrectionTask
- Use parameters extracted from LHC22o (very similar between different periods)
nstrangm
requested review from
alibuild,
maoyx,
mfasDa,
mhemmer-cern and
nzardosh
as code owners
github-actions
bot
changed the title
Collaborator
|
@fjonasALICE is this good to go? |
mhemmer-cern
approved these changes
Nov 18, 2024
Collaborator
mhemmer-cern
left a comment
mhemmer-cern
left a comment
There was a problem hiding this comment.
Looks good from EMCal side
fjonasALICE
approved these changes
Nov 18, 2024
Collaborator
fjonasALICE
left a comment
fjonasALICE
left a comment
There was a problem hiding this comment.
Ok from my side. Approach was presented and approved in EMCal meeting 👍
mhemmer-cern
changed the title
github-actions
bot
changed the title
christianreckziegel
pushed a commit
to christianreckziegel/O2Physics
that referenced
this pull request
Nov 19, 2024
…onTask (AliceO2Group#8513) Co-authored-by: Nicolas Strangmann <nicolas.strangmann@.cern.ch>
joachimckh
pushed a commit
to joachimckh/O2Physics
that referenced
this pull request
Dec 2, 2024
…onTask (AliceO2Group#8513) Co-authored-by: Nicolas Strangmann <nicolas.strangmann@.cern.ch>
joachimckh
pushed a commit
to joachimckh/O2Physics
that referenced
this pull request
Dec 2, 2024
…onTask (AliceO2Group#8513) Co-authored-by: Nicolas Strangmann <nicolas.strangmann@.cern.ch>
Archita-Dash
pushed a commit
to Archita-Dash/O2Physics
that referenced
this pull request
Dec 11, 2024
…onTask (AliceO2Group#8513) Co-authored-by: Nicolas Strangmann <nicolas.strangmann@.cern.ch>
feisenhu
pushed a commit
to feisenhu/O2Physics
that referenced
this pull request
Jan 8, 2025
…onTask (AliceO2Group#8513) Co-authored-by: Nicolas Strangmann <nicolas.strangmann@.cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.