Skip to content

[PWGLF] Initial commit of KF hypernuclei task#8612

Merged
njacazio merged 20 commits intoAliceO2Group:masterfrom
mhartung71:master
Nov 27, 2024
Merged

[PWGLF] Initial commit of KF hypernuclei task#8612
njacazio merged 20 commits intoAliceO2Group:masterfrom
mhartung71:master

Conversation

@mhartung71
Copy link
Contributor

Initial commit of KF hypernuclei task

@github-actions github-actions bot changed the title Initial commit of KF hypernuclei task [PWGLF] Initial commit of KF hypernuclei task Nov 22, 2024
@fmazzasc
Copy link
Collaborator

HI @mhartung71 , thanks for your work. I have two questions:

  • Why did't you use the 2- and 3- body structures that come out from the SVertexer? This has two pros: speed-up of your code as would avoid to redo the combinatorics, recover doblets/triplets where one of the prongs is not associated to the right collision
  • Could you delete redundant data members for your output tree? For example you store all the momenta of the daughters + the one of the mother

@mhartung71
Copy link
Contributor Author

Dear Francesco,

thank you very much for your quick reply. The code is created to reconstruct both single and double hypernuclei (e.g. 4LLH->4LHe+pi). However, the SVertexer is not optimized for the decay of double hypernuclei, so we decided to use the KFParticle package (KFP). Furthermore, we also want to check whether KFP achieves a higher reconstruction efficiency compared to the SVertexer (discussed by Maximiliano and Benjamin).

The different momenta of mother and daughter particles are not equivalent, since the mother momentum is optimized during the reconstruction by KFP. Calculating the mother momentum from the daughter momenta can lead to a reduction in resolution, with double hypernuclei being affected in particular, as the effect occurs twice. But we cannot yet say exactly how strong the impact is. Our plan is to start with a run over MC and a part of data (LHC23zzh_pass4_small). After the evaluation, we will revise the code and delete information from the tree that is not needed.

Best regards,
Michael and Janik

fmazzasc
fmazzasc previously approved these changes Nov 22, 2024
@fmazzasc fmazzasc enabled auto-merge (squash) November 22, 2024 18:28
@njacazio
Copy link
Collaborator

Hi, the macOS test is failing, I would start fixing this before going on with the merge

auto-merge was automatically disabled November 25, 2024 12:04

Head branch was pushed to by a user without write access

njacazio
njacazio previously approved these changes Nov 25, 2024
Copy link
Collaborator

@njacazio njacazio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, hopefully it should fix the CI

@njacazio njacazio enabled auto-merge (squash) November 27, 2024 14:41
@njacazio njacazio merged commit c4dcb22 into AliceO2Group:master Nov 27, 2024
joachimckh pushed a commit to joachimckh/O2Physics that referenced this pull request Dec 2, 2024
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
joachimckh pushed a commit to joachimckh/O2Physics that referenced this pull request Dec 2, 2024
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
wefeng1110 pushed a commit to wefeng1110/O2Physics that referenced this pull request Dec 6, 2024
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Archita-Dash pushed a commit to Archita-Dash/O2Physics that referenced this pull request Dec 11, 2024
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
hernasab pushed a commit to hernasab/O2Physics that referenced this pull request Dec 20, 2024
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
feisenhu pushed a commit to feisenhu/O2Physics that referenced this pull request Jan 8, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants