[PWGCF] Generic Framework: PID v2 by Preet-Bhanjan · Pull Request #8651 · AliceO2Group/O2Physics

Preet-Bhanjan · 2024-11-25T17:10:57Z

Using generic framework for computing the two-particle correlation v2 for pions, kaons, and protons.

alibuild · 2024-11-25T20:18:39Z

Error while checking build/O2Physics/o2 for 24db179 at 2024-11-25 21:18:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/8651-slc9_x86-64/0/PWGCF/GenericFramework/Tasks/FlowGFPbPbpikp.cxx:113:5: error: 'sTObjArray' was not declared in this scope; did you mean 'TObjArray'?
/sw/SOURCES/O2Physics/8651-slc9_x86-64/0/PWGCF/GenericFramework/Tasks/FlowGFPbPbpikp.cxx:113:17: error: 'oba' was not declared in this scope
/sw/SOURCES/O2Physics/8651-slc9_x86-64/0/PWGCF/GenericFramework/Tasks/FlowGFPbPbpikp.cxx:130:5: error: type '<type error>' argument given to 'delete', expected pointer
ninja: build stopped: subcommand failed.

Full log here.

victor-gonzalez

Please, don't use the GenericFramework directory. It is for the own GFW

This task was already created in the Flow directory which is where it should be placed

Why is not the one there updated?

Preet-Bhanjan · 2024-11-26T10:47:41Z

This task uses the GFW and so the GenericFramework directory was being used. However, since the same task is in the Flow directory, I will modify it to use the GFW.

…

On Mon, Nov 25, 2024 at 9:27 PM Victor Gonzalez ***@***.***> wrote: ***@***.**** requested changes on this pull request. Please, don't use the GenericFramework directory. It is for the own GFW This task was already created in the Flow directory which is where it should be placed Why is not the one there updated? — Reply to this email directly, view it on GitHub <#8651 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BKFU3W6VNCK5UQS7RNGJIE32COB2JAVCNFSM6AAAAABSOPMD62VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINJZGU3DAMJVHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[PWGCF] Please consider the following formatting changes to AliceO2Group#8651

PWGCF/Flow/Tasks/FlowPbPbpikp.cxx

victor-gonzalez · 2024-11-27T10:33:38Z

PWGCF/Flow/Tasks/FlowPbPbpikp.cxx

+    if (idprob.first == 0 || idprob.first == 1 || idprob.first == 2) { // 0 = pion, 1 = kaon, 2 = proton
+      pidID = idprob.first;
+      float nsigmaTPC[3] = {track.tpcNSigmaPi(), track.tpcNSigmaKa(), track.tpcNSigmaPr()};
+      if (idprob.second > maxProb[pidID]) {
+        if (abs(nsigmaTPC[pidID]) > 3)
+          return 0;
+        return pidID + 1; // shift the pid by 1, 1 = pion, 2 = kaon, 3 = proton


I would suggest using an enum for particle named constants and using it consistently
The function can return -1 (kWRONGID = -1) in case the identification is not accepted

victor-gonzalez

Please, remove from the PR the not affected file and also change the name of the task according to the functionality
The other comments are for your consideration in next iterations

PWGCF/GenericFramework/Tasks/CMakeLists.txt

alibuild · 2024-11-27T13:21:13Z

Error while checking build/O2Physics/o2 for 3e7fdc0 at 2024-11-27 14:21:

## sw/BUILD/O2Physics-latest/log
CMake Error at PWGCF/GenericFramework/CMakeLists.txt:13 (add_subdirectory):

Full log here.

[PWGCF] Please consider the following formatting changes to AliceO2Group#8651

alibuild · 2024-11-27T13:48:37Z

Error while checking build/O2Physics/o2 for b70ef6a at 2024-11-27 14:48:

## sw/BUILD/O2Physics-latest/log
CMake Error at PWGCF/GenericFramework/CMakeLists.txt:13 (add_subdirectory):

Full log here.

victor-gonzalez

The file PWGCF/GenericFramework/Tasks/CMakeLists.txt should not be part of this PR which means that it should not be modified by the PR. As it is right now the PR modify it and that's why it is included in the PR. It should not be included in the PR

victor-gonzalez · 2024-11-27T16:23:48Z

PWGCF/GenericFramework/Tasks/CMakeLists.txt

@@ -12,4 +12,4 @@
 o2physics_add_dpl_workflow(flow-generic-framework


This file should not be part of this PR

victor-gonzalez · 2024-11-27T16:47:08Z

@Preet-Bhanjan Please, don't close the PR, all the comments will be lost if you open a new one
Just modify your local repository restoring the original PWGCF/GenericFramework/Tasks/CMakeLists.txt before your changes and then push again towards your remote fork. That will update automatically the PR

[PWGCF] Please consider the following formatting changes to AliceO2Group#8651

victor-gonzalez

Thanks!

Co-authored-by: Preet Pati <preet@preet-2.local> Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

Preet-Bhanjan requested review from alibuild, ariedel-cern, lauraser, lgraczykCern, otonvd, prchakra, saganatt, shouqiye, victor-gonzalez and zchochul as code owners November 25, 2024 17:10

github-actions bot added the pwgcf label Nov 25, 2024

alibuild mentioned this pull request Nov 25, 2024

[PWGCF] Please consider the following formatting changes to #8651 Preet-Bhanjan/O2Physics#2

Closed

Preet-Bhanjan force-pushed the master branch from 4ed650e to 24db179 Compare November 25, 2024 17:33

victor-gonzalez requested changes Nov 25, 2024

View reviewed changes

Preet-Bhanjan force-pushed the master branch from 24db179 to 64db143 Compare November 26, 2024 12:53

alibuild mentioned this pull request Nov 26, 2024

[PWGCF] Please consider the following formatting changes to #8651 Preet-Bhanjan/O2Physics#3

Merged

Preet-Bhanjan added a commit to Preet-Bhanjan/O2Physics that referenced this pull request Nov 27, 2024

Merge pull request #3 from alibuild/alibot-cleanup-8651

d7fcd07

[PWGCF] Please consider the following formatting changes to AliceO2Group#8651

victor-gonzalez reviewed Nov 27, 2024

View reviewed changes

PWGCF/Flow/Tasks/FlowPbPbpikp.cxx Outdated Show resolved Hide resolved

victor-gonzalez reviewed Nov 27, 2024

View reviewed changes

PWGCF/Flow/Tasks/FlowPbPbpikp.cxx Outdated Show resolved Hide resolved

victor-gonzalez reviewed Nov 27, 2024

View reviewed changes

PWGCF/Flow/Tasks/FlowPbPbpikp.cxx Outdated Show resolved Hide resolved

victor-gonzalez reviewed Nov 27, 2024

View reviewed changes

victor-gonzalez requested changes Nov 27, 2024

View reviewed changes

PWGCF/GenericFramework/Tasks/CMakeLists.txt Show resolved Hide resolved

Preet-Bhanjan force-pushed the master branch from 4973b7a to 5af30c2 Compare November 27, 2024 13:38

alibuild mentioned this pull request Nov 27, 2024

[PWGCF] Please consider the following formatting changes to #8651 Preet-Bhanjan/O2Physics#4

Merged

Preet-Bhanjan added a commit to Preet-Bhanjan/O2Physics that referenced this pull request Nov 27, 2024

Merge pull request #4 from alibuild/alibot-cleanup-8651

3151ba3

[PWGCF] Please consider the following formatting changes to AliceO2Group#8651

alibuild mentioned this pull request Nov 27, 2024

[PWGCF] Please consider the following formatting changes to #8651 Preet-Bhanjan/O2Physics#5

Closed

victor-gonzalez requested changes Nov 27, 2024

View reviewed changes

Preet-Bhanjan closed this Nov 27, 2024

victor-gonzalez reopened this Nov 27, 2024

Recommiting the generic frmework pid code

c90c6dd

Preet-Bhanjan force-pushed the master branch from ed1dc14 to c90c6dd Compare November 27, 2024 16:56

Please consider the following formatting changes

5648bb7

alibuild mentioned this pull request Nov 27, 2024

[PWGCF] Please consider the following formatting changes to #8651 Preet-Bhanjan/O2Physics#6

Merged

Merge pull request #6 from alibuild/alibot-cleanup-8651

dd6f46c

[PWGCF] Please consider the following formatting changes to AliceO2Group#8651

alibuild mentioned this pull request Nov 27, 2024

[PWGCF] Please consider the following formatting changes to #8651 Preet-Bhanjan/O2Physics#7

Closed

Update9 FlowPbPbpikp.cxx

ad985f1

victor-gonzalez approved these changes Nov 27, 2024

View reviewed changes

victor-gonzalez merged commit d91eb8c into AliceO2Group:master Nov 27, 2024

joachimckh pushed a commit to joachimckh/O2Physics that referenced this pull request Dec 2, 2024

[PWGCF] Generic Framework: PID v2 (AliceO2Group#8651)

35a7bd6

Co-authored-by: Preet Pati <preet@preet-2.local> Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

joachimckh pushed a commit to joachimckh/O2Physics that referenced this pull request Dec 2, 2024

[PWGCF] Generic Framework: PID v2 (AliceO2Group#8651)

4ea6d75

Co-authored-by: Preet Pati <preet@preet-2.local> Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

wefeng1110 pushed a commit to wefeng1110/O2Physics that referenced this pull request Dec 6, 2024

[PWGCF] Generic Framework: PID v2 (AliceO2Group#8651)

afe9956

Co-authored-by: Preet Pati <preet@preet-2.local> Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

Archita-Dash pushed a commit to Archita-Dash/O2Physics that referenced this pull request Dec 11, 2024

[PWGCF] Generic Framework: PID v2 (AliceO2Group#8651)

47fcb3c

Co-authored-by: Preet Pati <preet@preet-2.local> Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

hernasab pushed a commit to hernasab/O2Physics that referenced this pull request Dec 20, 2024

[PWGCF] Generic Framework: PID v2 (AliceO2Group#8651)

bae4d3f

Co-authored-by: Preet Pati <preet@preet-2.local> Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

feisenhu pushed a commit to feisenhu/O2Physics that referenced this pull request Jan 8, 2025

[PWGCF] Generic Framework: PID v2 (AliceO2Group#8651)

f6116d1

Co-authored-by: Preet Pati <preet@preet-2.local> Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PWGCF] Generic Framework: PID v2#8651

[PWGCF] Generic Framework: PID v2#8651
victor-gonzalez merged 4 commits intoAliceO2Group:masterfrom
Preet-Bhanjan:master

Preet-Bhanjan commented Nov 25, 2024

Uh oh!

alibuild commented Nov 25, 2024

Uh oh!

victor-gonzalez left a comment

Uh oh!

Preet-Bhanjan commented Nov 26, 2024 via email

Uh oh!

Uh oh!

Uh oh!

Uh oh!

victor-gonzalez Nov 27, 2024

Uh oh!

victor-gonzalez left a comment

Uh oh!

Uh oh!

alibuild commented Nov 27, 2024

Uh oh!

alibuild commented Nov 27, 2024

Uh oh!

victor-gonzalez left a comment

Uh oh!

victor-gonzalez Nov 27, 2024

Uh oh!

victor-gonzalez commented Nov 27, 2024

Uh oh!

victor-gonzalez left a comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

		@@ -12,4 +12,4 @@
		o2physics_add_dpl_workflow(flow-generic-framework

Conversation

Preet-Bhanjan commented Nov 25, 2024

Uh oh!

alibuild commented Nov 25, 2024

Uh oh!

victor-gonzalez left a comment

Choose a reason for hiding this comment

Uh oh!

Preet-Bhanjan commented Nov 26, 2024 via email

Uh oh!

Uh oh!

Uh oh!

Uh oh!

victor-gonzalez Nov 27, 2024

Choose a reason for hiding this comment

Uh oh!

victor-gonzalez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alibuild commented Nov 27, 2024

Uh oh!

alibuild commented Nov 27, 2024

Uh oh!

victor-gonzalez left a comment

Choose a reason for hiding this comment

Uh oh!

victor-gonzalez Nov 27, 2024

Choose a reason for hiding this comment

Uh oh!

victor-gonzalez commented Nov 27, 2024

Uh oh!

victor-gonzalez left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants