[PWGHF,Trigger] Add de-Lc femto trigger channel into the HFFilter task#8937
Merged
zhangbiao-phy merged 20 commits intoAliceO2Group:masterfrom Dec 15, 2024
Merged
Conversation
Collaborator
zhangbiao-phy
commented
Dec 11, 2024
zhangbiao-phy
commented
- Add deuteron case for the Femto selected track
- Add deuteron pid case for the TPC post-calibration even we don't use it anymore
github-actions
bot
changed the title
Collaborator
Author
Please consider the following formatting changes to AliceO2Group#8937
fgrosa
requested changes
Dec 12, 2024
Collaborator
fgrosa
left a comment
fgrosa
left a comment
There was a problem hiding this comment.
Hi @zhangbiao-phy, thanks a lot! I agree to wait for @apalasciano PR before merging this one. I have anyway a couple of comments about the deuteron selection (see below). Good that you adapted the code for possible recalibrations, even if we do not use them it's good to have the possibility to apply them.
Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
Please consider the following formatting changes to AliceO2Group#8937
…logic for pt dependence PID selection
zhangbiao-phy
requested review from
alibuild,
lietava and
mpuccio
as code owners
fgrosa
requested changes
Dec 13, 2024
Collaborator
fgrosa
left a comment
fgrosa
left a comment
There was a problem hiding this comment.
Ciao @zhangbiao-phy thanks, I just have a remaining minor comment, then we can merge it I would say
Please consider the following formatting changes to AliceO2Group#8937
alibuild
approved these changes
Dec 13, 2024
Collaborator
alibuild
left a comment
alibuild
left a comment
There was a problem hiding this comment.
Auto-approving on behalf of @zhangbiao-phy.
fgrosa
approved these changes
Dec 15, 2024
hernasab
pushed a commit
to hernasab/O2Physics
that referenced
this pull request
Dec 20, 2024
AliceO2Group#8937) Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
feisenhu
pushed a commit
to feisenhu/O2Physics
that referenced
this pull request
Jan 8, 2025
AliceO2Group#8937) Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
smaff92
pushed a commit
to smaff92/O2Physics
that referenced
this pull request
Feb 17, 2025
AliceO2Group#8937) Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.