Skip to content

[Common] add extra MFT counters to mult table #8980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ddobrigk merged 6 commits into from
Dec 13, 2024
Merged

[Common] add extra MFT counters to mult table #8980

ddobrigk merged 6 commits into from
Dec 13, 2024

Conversation

@ddobrigk
Copy link
Collaborator

@ddobrigk ddobrigk commented Dec 13, 2024

No description provided.

@ddobrigk ddobrigk requested review from a team, alibuild, iarsene, jgrosseo and ktf as code owners December 13, 2024 14:22
@github-actions github-actions bot changed the title Common: add extra MFT counters to mult table [Common] add extra MFT counters to mult table Dec 13, 2024
@alibuild alibuild mentioned this pull request Dec 13, 2024
Merged
@ddobrigk ddobrigk enabled auto-merge (squash) December 13, 2024 14:25
alibuild
alibuild previously approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @ddobrigk.

@alibuild
Copy link
Collaborator

alibuild commented Dec 13, 2024

Error while checking build/O2Physics/o2 for dbf2e75 at 2024-12-13 15:26:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/8980-slc9_x86-64/0/Common/TableProducer/Converters/trackQA002Converter.cxx:25:32: error: 'tracksQA_001' was not declared in this scope; did you mean 'tracksQA_002'?
/sw/SOURCES/O2Physics/8980-slc9_x86-64/0/Common/TableProducer/Converters/trackQA002Converter.cxx:23:44: error: unused parameter 'tracksQA_000' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/8980-slc9_x86-64/0/Common/TableProducer/multiplicityTable.cxx:739:80: error: unused parameter 'collision' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented Dec 13, 2024

Error while checking build/O2Physics/o2 for 00f4cf8 at 2024-12-13 15:37:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/8980-slc9_x86-64/0/Common/TableProducer/multiplicityTable.cxx:739:80: error: unused parameter 'collision' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@ddobrigk ddobrigk disabled auto-merge December 13, 2024 21:35
@ddobrigk ddobrigk enabled auto-merge (squash) December 13, 2024 21:35
alibuild
alibuild approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @ddobrigk.

@ddobrigk ddobrigk merged commit 7826dc6 into AliceO2Group:master Dec 13, 2024
9 of 13 checks passed
@ddobrigk ddobrigk deleted the mftextras branch December 13, 2024 21:36
hernasab pushed a commit to hernasab/O2Physics that referenced this pull request Dec 20, 2024
@ddobrigk @alibuild
[Common] add extra MFT counters to mult table (AliceO2Group#8980)
4cf23e4 
Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
feisenhu pushed a commit to feisenhu/O2Physics that referenced this pull request Jan 8, 2025
@ddobrigk @alibuild @feisenhu
[Common] add extra MFT counters to mult table (AliceO2Group#8980)
f02e9e8 
Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Feb 17, 2025
@ddobrigk @alibuild @smaff92
[Common] add extra MFT counters to mult table (AliceO2Group#8980)
d218e12 
Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes

@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner

@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner

@ktf ktf Awaiting requested review from ktf ktf is a code owner

Assignees

No one assigned

Labels

common datamodel

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ddobrigk @alibuild