[PWGCF,PWGLF] Data model update#9510
Conversation
|
Just fix the mega linter |
|
Hi @victor-gonzalez could you please have a look? |
victor-gonzalez
left a comment
There was a problem hiding this comment.
Fine from my side
Please, for the next iterations start implementing linter recommendations
|
Tip top! Thanks! |
|
This is actually breaking the CI because it now creates an empty workflow if the tables are not present (like when we create the json in the builds). I can remove the protection, however that will result in an empty json. @jgrosseo will that create issues to HyperLoop? |
|
Hi @ktf this is a sort of pilot and uses the same procedure that we wanted to have in the unified converter and could be relevant also there. |
|
I will remove the check for now. In any case it should not be an assert, since whether or not the workflow is empty is not an internal detail and at the moment the check is only enforced in debug builds. Still we should understand what are the effects, since it means that effectively in the builds we will generate an empty workflow. |
|
@ktf An empty workflow means an empty json? |
@njacazio
@ercolessi