Skip to content

[DPG] Megalinter fixes #9560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
njacazio merged 1 commit into from
Jan 27, 2025
Merged

[DPG] Megalinter fixes #9560

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions DPG/Tasks/AOTTrack/PID/ITS/qaPIDITS.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.

Check warning on line 1 in DPG/Tasks/AOTTrack/PID/ITS/qaPIDITS.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/workflow-file] 

Name of a workflow file must match the name of the main struct in it (without the PWG prefix). (Class implementation files should be in "Core" directories.)
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
// All rights not expressly granted are reserved.
//
Expand All @@ -15,6 +15,9 @@
/// \brief Implementation for QA tasks of the ITS PID quantities
///

#include <string>
#include <vector>

#include "Framework/AnalysisTask.h"
#include "Framework/runDataProcessing.h"
#include "Framework/HistogramRegistry.h"
Expand All @@ -29,7 +32,7 @@
using namespace o2::framework::expressions;
using namespace o2::track;

static constexpr int nParameters = 1;

Check warning on line 35 in DPG/Tasks/AOTTrack/PID/ITS/qaPIDITS.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/constexpr-constant] 

Use UpperCamelCase for names of constexpr constants. Names of special constants may be prefixed with "k".
static const std::vector<std::string> tableNames{"Electron", // 0
"Muon", // 1
"Pion", // 2
Expand Down Expand Up @@ -132,9 +135,9 @@
float tofSelValues[9];

/// Task to produce the ITS QA plots
struct itsPidQa {

Check warning on line 138 in DPG/Tasks/AOTTrack/PID/ITS/qaPIDITS.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/struct] 

Use UpperCamelCase for names of structs.
static constexpr const char* pT[Np] = {"e", "#mu", "#pi", "K", "p", "d", "t", "^{3}He", "#alpha"};

Check warning on line 139 in DPG/Tasks/AOTTrack/PID/ITS/qaPIDITS.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/constexpr-constant] 

Use UpperCamelCase for names of constexpr constants. Names of special constants may be prefixed with "k".
static constexpr const char* pN[Np] = {"El", "Mu", "Pi", "Ka", "Pr", "De", "Tr", "He", "Al"};

Check warning on line 140 in DPG/Tasks/AOTTrack/PID/ITS/qaPIDITS.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/constexpr-constant] 

Use UpperCamelCase for names of constexpr constants. Names of special constants may be prefixed with "k".

HistogramRegistry histos{"Histos", {}, OutputObjHandlingPolicy::AnalysisObject};
Configurable<LabeledArray<int>> enabledTables{"enabledTables",
Expand All @@ -152,7 +155,7 @@
Configurable<float> minP{"minP", 0.01, "Minimum momentum in range"};
Configurable<float> maxP{"maxP", 20, "Maximum momentum in range"};
ConfigurableAxis etaBins{"etaBins", {100, -1.f, 1.f}, "Binning in eta"};
ConfigurableAxis phiBins{"phiBins", {100, 0, TMath::TwoPi()}, "Binning in phi"};

Check warning on line 158 in DPG/Tasks/AOTTrack/PID/ITS/qaPIDITS.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[external-pi] 

Consider using the PI constant (and its multiples and fractions) defined in o2::constants::math.
ConfigurableAxis trackLengthBins{"trackLengthBins", {100, 0, 1000.f}, "Binning in track length plot"};
ConfigurableAxis deltaBins{"deltaBins", {200, -1000.f, 1000.f}, "Binning in Delta (dEdx - expected dEdx)"};
ConfigurableAxis expSigmaBins{"expSigmaBins", {200, 0.f, 200.f}, "Binning in expected Sigma"};
Expand Down
Loading