Skip to content

[PWGCF] NUA corrections with CCDB connection#9868

Merged
victor-gonzalez merged 12 commits intoAliceO2Group:masterfrom
MaximVirta:master
Feb 11, 2025
Merged

[PWGCF] NUA corrections with CCDB connection#9868
victor-gonzalez merged 12 commits intoAliceO2Group:masterfrom
MaximVirta:master

Conversation

@MaximVirta
Copy link
Contributor

@MaximVirta MaximVirta commented Feb 11, 2025

No description provided.

@github-actions github-actions bot added the pwgcf label Feb 11, 2025
@alibuild alibuild mentioned this pull request Feb 11, 2025
Merged
MaximVirta and others added 2 commits February 11, 2025 10:58
@MaximVirta
Merge pull request #12 from alibuild/alibot-cleanup-9868
cf3f75d 
[PWGCF] Please consider the following formatting changes to AliceO2Group#9868
Megalinter changes
3e45a60
@alibuild alibuild mentioned this pull request Feb 11, 2025
Merged
@alibuild
Copy link
Collaborator

alibuild commented Feb 11, 2025

Error while checking build/O2Physics/o2 for 27b54f8 at 2025-02-11 12:08:

## sw/BUILD/O2Physics-latest/log
input_line_9:653:97: error: no member named 'constants' in namespace 'o2'
input_line_9:654:95: error: no member named 'constants' in namespace 'o2'
input_line_9:656:10: error: unknown type name 'Uint'
Error: /sw/slc9_x86-64/ROOT/v6-32-06-alice1-17/bin/rootcling: compilation failure (/sw/BUILD/a2705fc8b46d3f2bdadd5bad553ec3209f685722/O2Physics/PWGCF/JCorran/Core/G__O2PhysicsJCorranc59ed3c341_dictUmbrella.h)
ninja: build stopped: subcommand failed.

Full log here.

victor-gonzalez
victor-gonzalez approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@victor-gonzalez victor-gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for incorporating linter recommendations!
For future iterations remember to remove commented code that has been left with the latest update and also document the source and header files as suggested by linter

@victor-gonzalez victor-gonzalez merged commit 255ded7 into AliceO2Group:master Feb 11, 2025
11 of 13 checks passed
nasirmehdimalik pushed a commit to nasirmehdimalik/O2Physics that referenced this pull request Feb 12, 2025
@MaximVirta @alibuild @nasirmehdimalik
[PWGCF] NUA corrections with CCDB connection (AliceO2Group#9868)
6cd062d 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Feb 17, 2025
@MaximVirta @alibuild @smaff92
[PWGCF] NUA corrections with CCDB connection (AliceO2Group#9868)
b4036fc 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
alibuild added a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
@MaximVirta @alibuild @CesarOmarRA
[PWGCF] NUA corrections with CCDB connection (AliceO2Group#9868)
23e1b3f 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@victor-gonzalez victor-gonzalez victor-gonzalez approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@saganatt saganatt Awaiting requested review from saganatt

@zchochul zchochul Awaiting requested review from zchochul zchochul is a code owner

@lgraczykCern lgraczykCern Awaiting requested review from lgraczykCern lgraczykCern is a code owner

@prchakra prchakra Awaiting requested review from prchakra prchakra is a code owner

@lauraser lauraser Awaiting requested review from lauraser lauraser is a code owner

@ariedel-cern ariedel-cern Awaiting requested review from ariedel-cern ariedel-cern is a code owner

@otonvd otonvd Awaiting requested review from otonvd otonvd is a code owner

@shouqiye shouqiye Awaiting requested review from shouqiye shouqiye is a code owner

Assignees

No one assigned

Labels

pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MaximVirta @alibuild @victor-gonzalez