Skip to content

Don't rely on O2 for std pollution#1980

Merged
Barthelemy merged 2 commits intoAliceO2Group:masterfrom
Barthelemy:remove-std-pollution-o2
Sep 12, 2023
Merged

Don't rely on O2 for std pollution#1980
Barthelemy merged 2 commits intoAliceO2Group:masterfrom
Barthelemy:remove-std-pollution-o2

Conversation

@Barthelemy
Copy link
Collaborator

No description provided.

@mfasDa
Copy link
Collaborator

mfasDa commented Sep 12, 2023

@Barthelemy Thanks a lot for fixing! Hmmm, how did this enter ... ?

@vkucera
Copy link

vkucera commented Sep 12, 2023

Thanks @Barthelemy !

@Barthelemy
Copy link
Collaborator Author

@mfasDa O2 had a using namespace std leaking to us and it was hiding the problem. @vkucera fixed it but we have to fix it here first.

@Barthelemy Barthelemy merged commit f58b0ea into AliceO2Group:master Sep 12, 2023
@Barthelemy Barthelemy deleted the remove-std-pollution-o2 branch September 12, 2023 12:20
@vkucera
Copy link

vkucera commented Sep 12, 2023

I suspect it will require a new release to pick these changes up by the O2 checks. When can it be available?

@Barthelemy
Copy link
Collaborator Author

@vkucera I can make a new release v1.118 knowing that v1.117 is the one we keep and update for P2.

@Barthelemy
Copy link
Collaborator Author

@vkucera the release is here: alisw/alidist#5133

@vkucera
Copy link

vkucera commented Sep 12, 2023

Perfect! Thanks a lot @Barthelemy !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants