Skip to content

Conversation

@chiarazampolli
Copy link
Contributor

@chiarazampolli chiarazampolli commented Sep 27, 2023

Goes with AliceO2Group/AliceO2#11974.
To test:
o2-global-track-cluster-reader --tpc-track-reader "tpctracks.root --reader-delay 10" --shm-segment-size 64000000000 --disable-mc --hbfutils-config o2_tfidinfo.root --track-types "ITS,TPC,ITS-TPC" --cluster-types "TPC,ITS" | o2-qc --config json:///home/zampolli/work/O2/RelVal/CPU_6/QC_GLO.json -b
(json attached in a comment below).

@Barthelemy
Copy link
Collaborator

waiting for AliceO2Group/AliceO2#11974 to be merged then.

Please check the formatting issues.

@chiarazampolli
Copy link
Contributor Author

Yes, i will fix everything, including updating json.

@chiarazampolli
Copy link
Contributor Author

Moving to WIP while I fix the formatting etc.

@chiarazampolli
Copy link
Contributor Author

Not all jsons were tested. But I add here the one I did test, for data (extension is txt to be able to upload it here):
QC_GLO.txt

@knopers8 knopers8 enabled auto-merge (squash) October 5, 2023 09:12
@chiarazampolli
Copy link
Contributor Author

Hello @knopers8 ,
I think the error is not related to this PR... Maybe we can merge it?
Cheers,
Chiara

@knopers8
Copy link
Collaborator

knopers8 commented Oct 5, 2023

It's not related, but the build failed in O2 and did not reach QC because of it, so we do not know if it is going to fail in QC or not. Did you compile it on a mac by any chance?

@chiarazampolli
Copy link
Contributor Author

Ciao @knopers8 ,
No, I did not compile on mac. But the compilation for the PR in O2 worked. I don't know why.
If you check the changes, it is just replacing some getters with others, maybe we can merge? I don't know otherwise.
Cheers,
Chiara

@knopers8
Copy link
Collaborator

knopers8 commented Oct 5, 2023

The O2 check failed in a test, the build itself went fine actually. Anyway, I agree that we should not expect any surprises here. Usually the mac builds expose some implicit type conversions, but matchType::SIZE is int, so are your indexes in for loops and get* functions, so this should be fine.

I will force-merge and draft a release.

@knopers8 knopers8 disabled auto-merge October 5, 2023 12:34
@knopers8 knopers8 merged commit 576f0ed into AliceO2Group:master Oct 5, 2023
@chiarazampolli
Copy link
Contributor Author

Thanks!! Fingers crossed that all works fine :)

Barthelemy pushed a commit that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants