[OGUI-1840 & OGUI-1841] Refactor the response object of retrieveRunStatus
#3229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`retrieveRunInformation`
Collaborator
Author
|
The failing test is resolved in: #3230 |
graduta
requested changes
Dec 12, 2025
hehoon
changed the title
retrieveRunStatusretrieveRunStatus
5 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
graduta
requested changes
Dec 16, 2025
Member
graduta
left a comment
graduta
left a comment
There was a problem hiding this comment.
Nice progress! I added some comments for you to review
Member
There was a problem hiding this comment.
Given that Bookkeeping service is now returning more information, your tests should also be testing that.
Try to update the mock responses with fields that are not to be used so that you test here that your method only keeps fields that are intended
| * - RunStatus.ONGOING if the run is ongoing | ||
| * - RunStatus.ENDED if the run has completed (has timeO2End) | ||
| * - RunStatus.NOT_FOUND if there was an error or data is not available | ||
| * @returns {Promise<object>} - Returns a promise that resolves to the run information: |
Member
There was a problem hiding this comment.
This return doc would go well in a typedef file
| definition, | ||
| runQuality, | ||
| lhcBeamMode, | ||
| detectorQualities, |
Member
There was a problem hiding this comment.
As detectorQualities will probably be used with a map function to map to components, I think it would be good to add a default of [] in case bookkeeping fails to return you an expected value
…bject-of-retrieveRunStatus
graduta
approved these changes
Dec 17, 2025
graduta
deleted the
feature/QCG/OGUI-1840/Refactor-the-response-object-of-retrieveRunStatus
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have JIRA issue created
retrieveRunStatusis renamed toretrieveRunInformationrunStatus: this is the field created right now by QCG and should be kept to ensure front-end compatibilitystartTimeendTimeenvironmentIddefinitionrunQualitylhcBeamModedetectorQualitiesFilterServiceFilterController