Revert "test: increate the memory limit to TestRunWithMemoryswap2x"#2737
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2737 +/- ##
==========================================
+ Coverage 69.31% 69.32% +<.01%
==========================================
Files 278 278
Lines 17442 17442
==========================================
+ Hits 12090 12091 +1
+ Misses 4025 4024 -1
Partials 1327 1327
|
This reverts commit 69e6356. Signed-off-by: Ace-Tang <aceapril@126.com>
Ace-Tang
force-pushed
the
revert_memory_double_test
branch
from
9c97284 to
4321120
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 69e6356.
Ⅰ. Describe what this PR did
Thank for the wonderful work in opencontainers/runc#1984 slove this problem with bind way, by the way, it also sloved the kernel limit problem in opencontainers/runc#1979
After alibaba-archive/runc#20 merged, we can revert the change in
TestRunWithMemoryswap2x./cc @fuweid
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews