refactor: extract query engine to standalone ryx-query crate#39
Merged
Einswilli merged 15 commits intoAllDotPy:masterfrom Apr 8, 2026
Merged
refactor: extract query engine to standalone ryx-query crate#39Einswilli merged 15 commits intoAllDotPy:masterfrom
Einswilli merged 15 commits intoAllDotPy:masterfrom
Conversation
Split monolithic files into modular structure for better maintainability: - src/query/lookups/: - lookups.rs: Core types, registry, resolve() logic - common_lookups.rs: Comparison/string lookups (exact, gt, contains, etc.) - date_lookups.rs: Date/time transforms (year, month, day, hour, etc.) - json_lookups.rs: JSON transforms and lookups (key, has_key, etc.) - mod.rs: Re-exports - src/query/compiler/: - compiler.rs: Main SQL compiler implementation - helpers.rs: Internal helpers (quote_col, qualified_col, etc.) - mod.rs: Re-exports All 241 tests pass. No functional changes.
…s and date/time transforms
Remove the pub use re-exports of all_lookups and all_transforms from the lookups module to narrow the public API surface. These symbols are no longer exported from ryx-query::lookups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modularizes the query engine by extracting it into a standalone crate (
ryx-query), decoupling the SQL compilation logic from PyO3 dependencies.Key Changes:
ryx-querycrate.criterionbenchmarks to measure compilation speed, confirming high efficiency (sub-microsecond for simple queries).QueryErrorRyxError) for better clarity and seamless conversion to Python exceptions.