CHI_CheckInstallation: Check that we actually have installed with shortcuts on windows#2671
CHI_CheckInstallation: Check that we actually have installed with shortcuts on windows#2671
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the Windows installation health check to detect a common manual-install mistake where files are copied into “Igor Pro User Files” instead of being installed as shortcuts/links.
Changes:
- Add
CHI_CheckShortcuts()(Windows-only) to verify the “Igor Pro User Files” tree primarily contains.lnkshortcuts (with a few exceptions). - Invoke the new shortcut check from
CHI_CheckInstallation()on Windows.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
t-b
force-pushed
the
feature/2671-check-installation-shortcuts
branch
from
0124a3c to
32f35b9
Compare
t-b
force-pushed
the
feature/2671-check-installation-shortcuts
branch
from
32f35b9 to
deb6e44
Compare
There was a problem hiding this comment.
Pull request overview
Adds a Windows-specific installation validation to catch “copied files instead of shortcuts” installs, and improves test diagnostics by capturing and printing CHI_CheckInstallation() output.
Changes:
- Add
CHI_CheckShortcuts()and invoke it on Windows duringCHI_CheckInstallation(). - Update
UTF_VeryBasicHardwareTeststo capture History output fromCHI_CheckInstallation()and attach it to the test log.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| Packages/tests/HardwareBasic/UTF_VeryBasicHardwareTests.ipf | Captures and logs installation-check output to make failures diagnosable in CI. |
| Packages/MIES/MIES_CheckInstallation.ipf | Implements and wires in a Windows-only shortcut-vs-copied-files installation check. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…rtcuts on windows A common error when manually installing is that the files are copied and not linked. So let's check that as well.
This also outputs it to the stdout in the failing case.
t-b
force-pushed
the
feature/2671-check-installation-shortcuts
branch
from
3a8b8a3 to
9021f52
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
A common error when manually installing is that the files are copied and not linked. So let's check that as well.