Merged
Conversation
Closed
Contributor
|
@kaeldai The layout of the config json files in this example is quite different to the others here, with a mix of network and simulation setup. Is this intentional or can this be split out to have a circuit_config.json also? Or should tools support both? |
Collaborator
Author
|
@pgleeson Our tools support both. But I'm pretty sure the BBP tools require separating circuit and simulation config, as that's how it's described in the documentation. I would say you should at least support separate config files. And I will go ahead and update the example later today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding 5 cells current clamped example. This includes fixing all the issues with PR #27 and then some (I will remove that one).