Merged
Conversation
hernando
reviewed
Oct 2, 2018
| "cells": "biophys_cells", | ||
| "variable_name": "v", | ||
| "module": "extracellular", | ||
| "electrode_positions": "$COMPONENT_DIR/recXelectrodes/linear_electrode.csv", |
Collaborator
There was a problem hiding this comment.
Maybe it should be called COMPONENT_DIR in the spec. COMPONENTS_DIR doesn't sound correct English to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #40
For the 5-cell iclamp example simulation_config.json changed $COMPONENT_DIR to $COMPONENTS_DIR so the variable can be resolved in the manifest.
For the 9-cells example updated the build script to be able to resolve the full morphology path.