Skip to content

fix: parse combo models correctly when returned as objects #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
herjarsa wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

fix: parse combo models correctly when returned as objects #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/omniroute-combos.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ export async function resolveUnderlyingModels(
const combo = combos.get(modelId);
if (combo) {
console.log(`[OmniRoute] Resolved combo "${modelId}" to ${combo.models.length} underlying models`);
return combo.models;
return combo.models.map((m: any) => typeof m === 'string' ? m : (m.model || m.id));
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The current implementation is vulnerable to runtime crashes if the models array contains null values or objects that lack both model and id properties. Specifically, (m.model || m.id) will throw if m is null, and if both properties are missing, the map will return undefined. This leads to a crash in splitModelId (called later in calculateModelCapabilities) when it attempts to call .trim() on a non-string value.

Additionally, the OmniRouteCombo interface (line 17) should be updated to reflect the new API response structure (e.g., models: (string | { model?: string; id?: string })[]), which would allow for proper type checking instead of relying on any.

Suggested change
return combo.models.map((m: any) => typeof m === 'string' ? m : (m.model || m.id));
return combo.models.map((m: any) => typeof m === 'string' ? m : (m?.model ?? m?.id)).filter((m): m is string => typeof m === 'string');

}

// Not a combo, return as-is
Expand Down