Conversation
CapoMK25
requested review from
MikhailDeriabin,
PlayJeri and
hoan301298
as code owners
Collaborator
Author
|
JSDocs documentation went missing along the way for some reason again... added it back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description
Avatar Migration to an Object-Based Structure
This PR solves the feature request to add the Player Avatar data to include color data for each of the pieces.
Change list
numberto{ id, color }objects.ModifyAvatarDtoandUpdatePlayerDtoto handle nested validation..idproperties.createPlayerDtoBuilderand related mocks to fix the 32 failing suites caused by the type mismatch.