Needs upgrade for Broccoli

[NateDawg90]

My app currently is stuck on ember v3.14. When I upgrade to Ember 3.15 or later, I get the following error when running ember s:

`WARNING: Invalid Broccoli2 node detected, falling back to broccoli-builder. Broccoli error:

ReactFilter: The .read/.rebuild API is no longer supported as of Broccoli 1.0. Plugins must now derive from broccoli-plugin. https://github.com/broccolijs/broccoli/blob/master/docs/broccoli-1-0-plugin-api.md
used as input node to Analyzer (ember-auto-import-analyzer)
-- created here: --
at new Plugin (/Users/jnate/Projects/BFCore/frontend/node_modules/ember-auto-import/node_modules/broccoli-plugin/dist/index.js:47:36)
at new Analyzer (/Users/jnate/Projects/BFCore/frontend/node_modules/ember-auto-import/js/analyzer.js:72:9)
at AutoImport.analyze (/Users/jnate/Projects/BFCore/frontend/node_modules/ember-auto-import/js/auto-import.js:44:24)
at Object.toTree (/Users/jnate/Projects/BFCore/frontend/node_modules/ember-auto-import/js/index.js:31:59)
at /Users/jnate/Projects/BFCore/frontend/node_modules/ember-cli-preprocess-registry/preprocessors.js:188:26
at Array.forEach ()
at processPlugins (/Users/jnate/Projects/BFCore/frontend/node_modules/ember-cli-preprocess-registry/preprocessors.js:186:11)
at module.exports.preprocessJs (/Users/jnate/Projects/BFCore/frontend/node_modules/ember-cli-preprocess-registry/preprocessors.js:179:10)
at DefaultPackager.processJavascript (/Users/jnate/Projects/BFCore/frontend/node_modules/ember-cli/lib/broccoli/default-packager.js:503:29)
at DefaultPackager.processAppAndDependencies (/Users/jnate/Projects/BFCore/frontend/node_modules/ember-cli/lib/broccoli/default-packager.js:240:35)
-- (end) -----------------

WatcherAdapter's first argument must be an array of SourceNodeWrapper nodes`

It looks like the React addon needs updating, it's still using Broccoli v1. The dependencies of ember-cli-react v1.0.2 are:
broccoli-react "^0.8.0" ember-auto-import "^1.0.1" ember-cli-babel "^6.3.0" react "^15.5.4 || ^16.0.0" react-dom "^15.5.4 || ^16.0.0"
The versions of broccoli-react and ember-auto-import in particular are really old. Perhaps updating them will do the trick?

[pswai]

Let me take a look during the weekend :)

…

________________________________ From: Nate Johnson ***@***.***> Sent: Friday, September 3, 2021 5:58:10 AM To: AltSchool/ember-cli-react ***@***.***> Cc: Subscribed ***@***.***> Subject: [AltSchool/ember-cli-react] Needs upgrade for Broccoli (#50) My app currently is stuck on ember v3.14. When I upgrade to Ember 3.15 or later, I get the following error when running ember s: `WARNING: Invalid Broccoli2 node detected, falling back to broccoli-builder. Broccoli error: ReactFilter: The .read/.rebuild API is no longer supported as of Broccoli 1.0. Plugins must now derive from broccoli-plugin. https://github.com/broccolijs/broccoli/blob/master/docs/broccoli-1-0-plugin-api.md used as input node to Analyzer (ember-auto-import-analyzer) -- created here: -- at new Plugin (/Users/jnate/Projects/BFCore/frontend/node_modules/ember-auto-import/node_modules/broccoli-plugin/dist/index.js:47:36) at new Analyzer (/Users/jnate/Projects/BFCore/frontend/node_modules/ember-auto-import/js/analyzer.js:72:9) at AutoImport.analyze (/Users/jnate/Projects/BFCore/frontend/node_modules/ember-auto-import/js/auto-import.js:44:24) at Object.toTree (/Users/jnate/Projects/BFCore/frontend/node_modules/ember-auto-import/js/index.js:31:59) at /Users/jnate/Projects/BFCore/frontend/node_modules/ember-cli-preprocess-registry/preprocessors.js:188:26 at Array.forEach () at processPlugins (/Users/jnate/Projects/BFCore/frontend/node_modules/ember-cli-preprocess-registry/preprocessors.js:186:11) at module.exports.preprocessJs (/Users/jnate/Projects/BFCore/frontend/node_modules/ember-cli-preprocess-registry/preprocessors.js:179:10) at DefaultPackager.processJavascript (/Users/jnate/Projects/BFCore/frontend/node_modules/ember-cli/lib/broccoli/default-packager.js:503:29) at DefaultPackager.processAppAndDependencies (/Users/jnate/Projects/BFCore/frontend/node_modules/ember-cli/lib/broccoli/default-packager.js:240:35) -- (end) ----------------- WatcherAdapter's first argument must be an array of SourceNodeWrapper nodes` It looks like the React addon needs updating, it's still using Broccoli v1. The dependencies of ember-cli-react are: broccoli-react "^0.8.0" ember-auto-import "^1.0.1" ember-cli-babel "^6.3.0" react "^15.5.4 || ^16.0.0" react-dom "^15.5.4 || ^16.0.0" The versions of broccoli-react and ember-auto-import in particular are really old. Perhaps updating them will do the trick? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#50>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABIWQU25CG3QDAUQXRLENSDT77XPFANCNFSM5DKCFEFQ>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[pswai]

@NateDawg90 I have fixed this issue on my fork at https://www.npmjs.com/package/ember-cli-react-fork. The fork replaced broccoli-react with broccoli-babel-transpiler that is more maintained and updated.

The fork is a drop-in replacement so you shouldn't need to make too much changes other than modifying your package.json. From the tests result it should support until Ember 3.28 and React 17. However I haven't tested against newer Ember features (Glimmer components) and React features (context, hooks) yet, will do so when I have some time this week.

[NateDawg90]

Thanks, taking out broccoli-react looks promising and might be just what we need.

I did however get an error when installing with ember install ember-cli-react-fork:

Cannot find module '/Users/jnate/Projects/BFCore/frontend/node_modules/json5/lib/json5.js'. Please verify that the package.json has a valid "main" entry

Stack Trace and Error Report: /var/folders/5s/zdg5n7f50x5285mvdrrm3p580000gp/T/error.dump.502a145735d0ec6851e48b84c1077363.log
An error occurred in the constructor for ember-auto-import at /Users/jnate/Projects/BFCore/frontend/node_modules/ember-cli-react-fork/node_modules/ember-auto-import

An error occurred in the constructor for ember-cli-react-fork at /Users/jnate/Projects/BFCore/frontend/node_modules/ember-cli-react-fork

[NateDawg90]

Installing with yarn has no issues.

But when I start my app with ember s,

Build Error (broccoli-persistent-filter:Babel) in bitfusion/components/heatmap.jsx

Cannot find module '@babel/preset-react'
Require stack:

• /Users/jnate/Projects/BFCore/frontend/node_modules/@babel/core/lib/config/files/plugins.js
• /Users/jnate/Projects/BFCore/frontend/node_modules/@babel/core/lib/config/files/index.js
• /Users/jnate/Projects/BFCore/frontend/node_modules/@babel/core/lib/index.js
• /Users/jnate/Projects/BFCore/frontend/node_modules/broccoli-babel-transpiler/lib/worker.js

[pswai]

@NateDawg90 that looks like the dependency is not picked up properly. Can you try installing @babel/preset-react to your project and try again? I’ll take a look at it tonight

[NateDawg90]

I did install @babel/preset-react and it fixed that particular issue. Thanks!

Unfortunately now I have more problems. I'm currently running ember-cli v3.14 and ember-source 3.4, and when I try to upgrade ember-source to version 3.6 onwards, I get the following runtime error:

Uncaught Error: Could not find module ember-views/lib/compat/attrs

[pswai]

@NateDawg90 hmmm that is unexpected. I have some time today let me try to do some thorough checks.

[NateDawg90]

It might be an edge case of mismatched Ember versions. I got all my versions at 3.12 and it seems to be working now. Still something to look at.

[pswai]

@NateDawg90 very likely. I’m going to change the logic to gracefully fallback to previous path if the latest one is not found. That should be more robust

[pswai]

@NateDawg90 I have published the loader fallback mechanism in v2.0.1, can you try that?

[NateDawg90]

Looks good @pswai . I'm going to close this ticket for inactivity