Documentation for Swarm features in Antalya branch #1165
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <named_collections> | ||
| <iceberg_conf> | ||
| <url>http://test.s3.amazonaws.com/clickhouse-bucket/</url> | ||
| <access_key_id>test<access_key_id> |
There was a problem hiding this comment.
The Altinity example for icebergCluster named collections shows <access_key_id>test<access_key_id> without a closing tag, so anyone copying it would end up with invalid XML and ClickHouse will refuse to parse the named collection. Close the tag as </access_key_id> to make the sample usable.
Useful? React with 👍 / 👎.
|
|
||
| icebergAzure(connection_string|storage_account_url, container_name, blobpath, [,account_name], [,account_key] [,format] [,compression_method]) SETTINGS object_storage_cluster='cluster_name' | ||
|
|
||
| icebergHDSF(path_to_table, [,format] [,compression_method]) SETTINGS object_storage_cluster='cluster_name' |
There was a problem hiding this comment.
In the object_storage_cluster section the example calls icebergHDSF(...); the table function is spelled icebergHDFS, so the documented command would fail with an unknown function error if run as written.
Useful? React with 👍 / 👎.
|
|
||
| icebergLocal(path_to_table, [,format] [,compression_method]) SETTINGS object_storage_cluster='cluster_name' | ||
|
|
||
| icebergS3(option=value [,..]]) SETTINGS object_storage_cluster='cluster_name' |
There was a problem hiding this comment.
icebergS3 settings example
The alternative syntax shows icebergS3(option=value [,..]]) SETTINGS ... with an extra closing bracket; as written this is not valid table function syntax and will raise a parse error if copied. Dropping the stray ] makes the example executable.
Useful? React with 👍 / 👎.
Documentation for Swarm features in Antalya branch
|
QA verified. The cluster_name is missing in one of the examples. A comment has been left. |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Documentation for Swarm features in Antalya branch
Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: