forked from ClickHouse/ClickHouse
-
Notifications
You must be signed in to change notification settings - Fork 14
Profile events for task distribution in ObjectStorageCluster requests #1172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zvonand
merged 5 commits into
antalya-25.8
from
feature/antalya-25.8/object_storage_cluster_profile_events
Dec 8, 2025
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
39faf6e
Profile events for task distribution in ObjectStorageCluster requests
ianton-ru 1f8c298
Fix ObjectStorageClusterWaitingMicroseconds
ianton-ru 2092077
Fix spelling
ianton-ru 649ef3a
Merge branch 'antalya-25.8' into feature/antalya-25.8/object_storage_…
Enmk 44b9bed
Merge branch 'antalya-25.8' into feature/antalya-25.8/object_storage_…
zvonand File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,6 +3,12 @@ | |
| #include <consistent_hashing.h> | ||
| #include <optional> | ||
|
|
||
| namespace ProfileEvents | ||
| { | ||
| extern const Event ObjectStorageClusterSentToMatchedReplica; | ||
| extern const Event ObjectStorageClusterSentToNonMatchedReplica; | ||
| }; | ||
|
|
||
| namespace DB | ||
| { | ||
|
|
||
|
|
@@ -129,6 +135,7 @@ ObjectInfoPtr StorageObjectStorageStableTaskDistributor::getPreQueuedFile(size_t | |
| number_of_current_replica | ||
| ); | ||
|
|
||
| ProfileEvents::increment(ProfileEvents::ObjectStorageClusterSentToMatchedReplica); | ||
| return next_file; | ||
| } | ||
|
|
||
|
|
@@ -180,6 +187,7 @@ ObjectInfoPtr StorageObjectStorageStableTaskDistributor::getMatchingFileFromIter | |
| file_path, number_of_current_replica | ||
| ); | ||
|
|
||
| ProfileEvents::increment(ProfileEvents::ObjectStorageClusterSentToMatchedReplica); | ||
| return object_info; | ||
| } | ||
| LOG_TEST( | ||
|
|
@@ -236,6 +244,7 @@ ObjectInfoPtr StorageObjectStorageStableTaskDistributor::getAnyUnprocessedFile(s | |
| number_of_matched_replica | ||
| ); | ||
|
|
||
| ProfileEvents::increment(ProfileEvents::ObjectStorageClusterSentToNonMatchedReplica); | ||
| return next_file; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are we sure that replica is not matched here?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, here is only when no matched files anymore. |
||
| } | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file now declares
ProfileEvents::ObjectStorageClusterSentToMatchedReplica/...NonMatchedReplicaand callsProfileEvents::increment, but it never includes<Common/ProfileEvents.h>, soEventandincrementare undefined in this translation unit. As written the code will not compile after this commit; the missing header (or forward declaration ofincrementplus theEventtypedef) needs to be added.Useful? React with 👍 / 👎.