Skip to content

Set max message size on parquet v3 reader #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zvonand merged 3 commits into from
Dec 10, 2025
Merged

Set max message size on parquet v3 reader #1198

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a5d1d1
max msg size parquet reader v3
arthurpassos Dec 8, 2025
ae038bb
empty to retrigger ci
arthurpassos Dec 8, 2025
8b96e89
Merge branch 'antalya-25.8' into max_message_side_reader_v3
arthurpassos Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Processors/Formats/Impl/Parquet/ThriftUtil.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,13 @@ size_t deserializeThriftStruct(T & out, const char * buf, size_t limit)
/// TMemoryBuffer promises to not write to the buffer (in OBSERVE mode),
/// so it should be ok to const_cast.
uint8_t * cast_buf = const_cast<uint8_t *>(reinterpret_cast<const uint8_t *>(buf));
auto trans = std::make_shared<apache::thrift::transport::TMemoryBuffer>(cast_buf, uint32_t(limit));

/// Set max message size to avoid 'apache::thrift::transport::TTransportException: MaxMessageSize reached' on big files
/// Similar to https://github.com/ClickHouse/arrow/blob/5cfccd8ea65f33d4517e7409815d761c7650b45d/cpp/src/parquet/thrift_internal.h#L437
auto configuration = std::make_shared<apache::thrift::TConfiguration>();
configuration->setMaxMessageSize(std::numeric_limits<int>::max());
auto trans = std::make_shared<apache::thrift::transport::TMemoryBuffer>(cast_buf, uint32_t(limit), apache::thrift::transport::TMemoryBuffer::OBSERVE, configuration);

apache::thrift::protocol::TCompactProtocolT<apache::thrift::transport::TMemoryBuffer> proto(trans);
uint32_t bytes_read = out.read(&proto);
chassert(size_t(bytes_read + trans->available_read()) == limit);
Expand Down
Loading