Skip to content

Conversation

@ianton-ru
Copy link

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Solved #1228
Fix confusing cluster name and named collection name in cluster functions

Documentation entry for user-facing changes

This query failed with error There is no named collection 'cluster'

SELECT * FROM icebergCluster(cluster, connection)

but next queries works:

SELECT * FROM icebergS3Cluster(cluster, connection)
SELECT * FROM icebergCluster(cluster, connection, storage_type='s3')
SELECT * FROM icebergCluster('cluster', connection)

In query

SELECT * FROM icebergCluster(cluster, connection)

first argument is a cluster name, second is a named collection name with storage parameters.
icebergCluster table function also can have named argument storage_type with type of storage - s3/azure/hdfs/local.
By default storage_type is s3 to backward compatibility, icebergCluster was an alias for icebergS3Cluster.

If storage_type is not found in arguments, clickhouse tries to find it in named collection. This must be on early stage to select proper realization - icebergS3Cluster, icebergAzureCluster, etc.

So code tries to find named collection name in argument list, and interpret first identifier argument as name: https://github.com/Altinity/ClickHouse/blob/antalya-25.8/src/Storages/NamedCollectionsHelpers.cpp#L30

But in list cluster, connection cluster name is also identifier, and code chooses it as name of collection.

In this fix known cluster name is removed from arguments before named collection finding.

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • Tiered Storage (2h)

@github-actions
Copy link

Workflow [PR], commit [8d72946]

@zvonand
Copy link
Collaborator

zvonand commented Dec 18, 2025

03442_alter_delete_empty_part seems unrelated

@zvonand zvonand merged commit d4794d3 into antalya-25.8 Dec 18, 2025
137 of 139 checks passed
@alsugiliazova alsugiliazova added the verified Verified by QA label Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants