-
Notifications
You must be signed in to change notification settings - Fork 14
Add support for ALIAS columns in segments for engine=Hybrid #1272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@filimonov please check my comment #1290 (comment) |
Store ALIAS expressions in insertion order to keep output column ordering stable in distributed queries, and track alias names separately for membership checks.
… to avoid alias issues
8797994 to
d3b7738
Compare
Enmk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Stateless test failed because of the timeout Rerun did not help. |
Does not look related to the hybrid Looks like The query was (slowly) running. |
|
@filimonov test_threads_oversubscription this integration test fail looks like data race In total 5 integration tests are failing (some with connection refused): FAIL | test_scheduler_cpu_preemptive/test.py::test_threads_oversubscription | 62.40 | |
|
Regarding the integration test failures: Looking at the Altinity history database (link), the failures under However, looking at the upstream history database (link), we can see that this test is unstable there as well, failing intermittently over the past few months. Also, |
|
Regarding the stateless failure, after checking the history database (link), I was able to find the same failure occurring multiple times. For example, it happened in PR #1232 on Dec 16 (CI report). Based on this, neither the integration nor the stateless failures appear to be introduced by this PR. |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Now engine=Hybrid can access columns which are defined as ALIAS in segments.
Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: