Skip to content

Conversation

@filimonov
Copy link
Member

@filimonov filimonov commented Jan 7, 2026

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Now engine=Hybrid can access columns which are defined as ALIAS in segments.

Documentation entry for user-facing changes

...

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • Tiered Storage (2h)

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Workflow [PR], commit [386df14]

@alsugiliazova
Copy link
Member

alsugiliazova commented Jan 14, 2026

Current issues:
#1290
#1291
#1295
#1296

@alsugiliazova alsugiliazova added the verified-with-issue Verified by QA and issue(s) found. label Jan 14, 2026
@alsugiliazova
Copy link
Member

@filimonov please check my comment #1290 (comment)
Got another exception message in current issue after updates to the code

Store ALIAS expressions in insertion order to keep output column ordering
stable in distributed queries, and track alias names separately for
membership checks.
Copy link
Member

@Enmk Enmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alsugiliazova
Copy link
Member

Here the issue that needs to be reviewed: #1335
And also this minor one #1336 (hybrid in general, not alias)

@alsugiliazova
Copy link
Member

Stateless test failed because of the timeout

DB::Exception: Estimated query execution time (791.79482 seconds) is too long.

Rerun did not help.
@filimonov can you take a look?
https://altinity-build-artifacts.s3.amazonaws.com/json.html?PR=1272&sha=386df14915bf24c45c27485c4a73af783eb9db7a&name_0=PR&name_1=Stateless%20tests%20%28amd_asan%2C%20flaky%20check%29

@filimonov
Copy link
Member Author

Stateless test failed because of the timeout

DB::Exception: Estimated query execution time (791.79482 seconds) is too long.

Rerun did not help. @filimonov can you take a look? https://altinity-build-artifacts.s3.amazonaws.com/json.html?PR=1272&sha=386df14915bf24c45c27485c4a73af783eb9db7a&name_0=PR&name_1=Stateless%20tests%20%28amd_asan%2C%20flaky%20check%29

Does not look related to the hybrid

Looks like The query was (slowly) running.
https://gist.github.com/filimonov/5d9f99ef0c24cc697b09d45adfcaa2cb

@alsugiliazova
Copy link
Member

alsugiliazova commented Jan 27, 2026

@filimonov test_threads_oversubscription this integration test fail looks like data race

E           Exception: Sanitizer assert found for instance ==================
E           WARNING: ThreadSanitizer: data race (pid=10)
E             Write of size 1 at 0x7248001001b8 by thread T684:

https://altinity-build-artifacts.s3.amazonaws.com/PRs/1272/386df14915bf24c45c27485c4a73af783eb9db7a//integration_tests_amd_tsan_3_6/integration_run_parallel_0.log

In total 5 integration tests are failing (some with connection refused):

FAIL | test_scheduler_cpu_preemptive/test.py::test_threads_oversubscription | 62.40 |  
FAIL | test_scheduler_cpu_preemptive/test.py::test_cpu_time_fairness[random_longer_prd] | 7.99 |  
FAIL | test_scheduler_cpu_preemptive/test.py::test_create_workload | 0.70 |  
FAIL | test_scheduler_cpu_preemptive/test.py::test_independent_pools | 0.70 |  
FAIL | test_s3_cache_locality/test.py::test_cache_locality[0]

@CarlosFelipeOR
Copy link
Collaborator

CarlosFelipeOR commented Jan 27, 2026

Regarding the integration test failures:

Looking at the Altinity history database (link), the failures under test_scheduler_cpu_preemptive only appeared in PR #1272 and in one run of PR #1269 (3 failures in that run). They passed in the last run of #1269. In PR #1272, the tests failed repeatedly.

However, looking at the upstream history database (link), we can see that this test is unstable there as well, failing intermittently over the past few months.

Also, test_s3_cache_locality/test.py::test_cache_locality[0] is unstable and was added as a BROKEN test in #1334.

@CarlosFelipeOR
Copy link
Collaborator

Regarding the stateless failure, after checking the history database (link), I was able to find the same failure occurring multiple times. For example, it happened in PR #1232 on Dec 16 (CI report).

Based on this, neither the integration nor the stateless failures appear to be introduced by this PR.

@zvonand zvonand merged commit 59d7602 into antalya-25.8 Jan 28, 2026
1366 of 1399 checks passed
@alsugiliazova alsugiliazova added the verified Verified by QA label Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

8 participants