Skip to content

(maybe) Fix zero‑copy unlock check before part dir move #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
filimonov wants to merge 1 commit into
base: releases/25.8.15
Choose a base branch
from
+5 −0
Open

(maybe) Fix zero‑copy unlock check before part dir move #1353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Storages/MergeTree/DataPartStorageOnDiskBase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -747,6 +747,11 @@ void DataPartStorageOnDiskBase::remove(

try
{
/// Evaluate can_remove_callback before moving the directory so zero-copy reference checks
/// use the current (existing) path. We intentionally don't update part_dir to avoid races.
if (!can_remove_description)
can_remove_description.emplace(can_remove_callback());

disk->moveDirectory(from, to);
/// NOTE: we intentionally don't update part_dir here because it would cause a data race
/// with concurrent readers (e.g. system.parts table queries calling getFullPath()).
Expand Down
Loading