Draft
Conversation
AltraMayor
added
Enhancement
Feature request
Checking if the loop device was actually created before trying to delete it at step "Cleanup loop device". This prevents the error: "losetup: option requires an argument -- 'd'". Ensuring the package lists are up to date to avoid the 404 (Not Found) errors during package installation. These issues only affect the Linux platform.
This commit is needed to enable libprobe to employ libflow.
Introducing struct write_info reduces the number of parameters passed to helper functions, and prepare the code to employ libflow. This commit also renames high_level_reset() to overwhelm_cache() since device resets has been removed.
AltraMayor
force-pushed
the
probe_flow
branch
2 times, most recently
from
070a890 to
47176b3
Compare
The current code accounts time in miliseconds and microseconds. With top-tier PCIe 5.0 NVMe SSDs delivering sequential read rates up to 14,900 MB/s and sequential write rates up to 13,800 MB/s, these units are too coarse. This commit shifts to the units microseconds and nanoseconds.
There is no external users of has_enough_measurements().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Employing libflow in
f3probeenablesf3probeto report progress to users while reading and writing blocks.f3probeonly reports progress when the flag--verboseis on.There's potential for higher I/O throughput, but this may not be readily apparent since
f3probeis running a new probing algorithm. In addition, libflow will enable future features, including the parameters--max-write-rateand--max-read-rate.This pull request closes #122.