Fix clearVault to return actual deletion outcome instead of always true#39
Merged
mocolicious merged 2 commits intochen/fix-errorhandlingfrom Mar 21, 2026
Merged
Conversation
Co-authored-by: mocolicious <6373607+mocolicious@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on error handling improvements
Fix Mar 14, 2026
clearVault to return actual deletion outcome instead of always true
mocolicious
approved these changes
Mar 21, 2026
mocolicious
approved these changes
Mar 21, 2026
mocolicious
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VaultStorage.clearVault()unconditionally returnedtrue, making it impossible for callers to distinguish between "vault existed and was deleted" vs "vault never existed" — contradictingVaultManager.clearVault()'s KDoc which documentsfalsefor the latter case.Change
VaultStorage.clearVault()now checks vault existence before purging and returns the real outcome:true→ vault existed and was removed;false→ vault was not present. Behavior is now consistent with documented semantics inVaultManager.💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.