Fix VaultLockedException crash in resolveSigner() before biometric unlock#41
Draft
Copilot wants to merge 2 commits intochen/fix-errorhandlingfrom
Draft
Fix VaultLockedException crash in resolveSigner() before biometric unlock#41Copilot wants to merge 2 commits intochen/fix-errorhandlingfrom
Copilot wants to merge 2 commits intochen/fix-errorhandlingfrom
Conversation
…e biometric unlock Co-authored-by: mocolicious <6373607+mocolicious@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on error handling fixes
Fix VaultLockedException crash in resolveSigner() before biometric unlock
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolveSigner()accessedsigner.publicKeyfor an account-match check before biometric unlock. ForVaultSigner, this throwsVaultLockedExceptionwhen the key isn't cached yet — crashing the operation even though the subsequentensureBiometricAuth()call would have unlocked and cached it.Changes
resolveSigner()— wrapspublicKeyaccess incatch(VaultLockedException), skipping the eager account check when the vault is locked and deferring it to post-unlockverifyAccountMatch(signer, account)— performs the deferred account-match check after unlock; re-throwsVaultLockedExceptiondirectly if the vault is still locked (rather than letting a confusingIllegalArgumentExceptionsurface with no key available)transferToken,createAccount,closeAccount,swapInstruction,swap) — callverifyAccountMatch()immediately afterensureBiometricAuth()resolveSignersForBatch()— sameVaultLockedExceptioncatch applied; full per-option validation falls through toresolveSignerForAccount()inside theforEachloop once the vault is open📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.