Fix isKeyPermanentlyInvalidated to walk full exception cause chain#42
Draft
Copilot wants to merge 2 commits intochen/fix-errorhandlingfrom
Draft
Fix isKeyPermanentlyInvalidated to walk full exception cause chain#42Copilot wants to merge 2 commits intochen/fix-errorhandlingfrom
Copilot wants to merge 2 commits intochen/fix-errorhandlingfrom
Conversation
Co-authored-by: mocolicious <6373607+mocolicious@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on error handling improvements in PR #38
Fix isKeyPermanentlyInvalidated to walk full exception cause chain
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isKeyPermanentlyInvalidated()only checked the top-level exception class, while keystore/crypto failures are frequently wrapped. This meant biometric key invalidation could be silently misclassified as a generic init or decrypt failure.Changes
VaultStorage.kt: RewroteisKeyPermanentlyInvalidated()to traverse the fullcausechain, mirroring the existing pattern inisStaleKeyset()BiometricInvalidatedExceptionis now reliably thrown whereverKeyPermanentlyInvalidatedExceptionappears in the chain, regardless of wrapping depth.💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.