Skip to content

Conversation

@fpaul-1A
Copy link
Contributor

@fpaul-1A fpaul-1A commented Dec 1, 2025

Proposed change

Missing:

  • ngx-markdown still has a peer dependency on zone.js
    -> non-blocking, issue is tracked here Zone.js as optional dependency jfcere/ngx-markdown#524
  • @nx/angular not updated to angular 21
    -> fixed in 22.3.0-beta
  • design-factory, @agnos-ui/angular-bootstrap not updated to angular 21
  • jest-preset-angular not updated to angular 21
    -> fixed in 16.0
  • @ngrx/router-store not updated to angular 21
    -> updated in 21.0.0-beta
  • @angular-builders/jest not updated to angular 21
    -> fixed in 21.0.0-beta
  • ngx-monaco-editor-v2 not updated to angular 21
    -> fix bugs and move to angular 21 miki995/ngx-monaco-editor-v2#44

Related issues

- No issue associated -

@nx-cloud
Copy link

nx-cloud bot commented Dec 1, 2025

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable them in workspace settings.


View your CI Pipeline Execution ↗ for commit fccd02e

Command Status Duration Result
nx run-many --target=build,build-swagger ❌ Failed 12m 47s View ↗
nx affected --target=test --collectCoverage --c... ❌ Failed 4m 58s View ↗
nx affected --target=lint --configuration ci ✅ Succeeded 14m 21s View ↗
nx run ama-sdk-schematics:build-swagger ✅ Succeeded 3m 3s View ↗
nx affected --target=package-github-action ✅ Succeeded 2m 1s View ↗
nx run-many --tui=false --target=build --projec... ✅ Succeeded 38s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-07 11:11:26 UTC

@fpaul-1A fpaul-1A force-pushed the chore/angular-21 branch 3 times, most recently from 32661d2 to 13a1d6b Compare December 5, 2025 14:47
@fpaul-1A fpaul-1A force-pushed the chore/angular-21 branch 4 times, most recently from 400d0d7 to 6074806 Compare December 8, 2025 20:40
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.54%. Comparing base (555743c) to head (229fe96).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../src/tools/component-replacement/c11n-directive.ts 0.00% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fpaul-1A fpaul-1A force-pushed the chore/angular-21 branch 7 times, most recently from 7e00dd6 to 2db2ae4 Compare December 11, 2025 17:32
@fpaul-1A fpaul-1A changed the base branch from main to release/14.0.0-next December 12, 2025 10:58
"exclude": [],
"references": [
{
"path": "./tsconfig.build.composite.json"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need it anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's only used for composite build which was not working

"module": "CommonJS",
"moduleResolution": "node10",
"rootDir": ".",
"skipLibCheck": true, // because of @angular/core
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why exactly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@fpaul-1A fpaul-1A force-pushed the chore/angular-21 branch 5 times, most recently from 7046a16 to 229fe96 Compare December 17, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

project:@ama-mcp/angular project:@ama-mcp/core project:@ama-mcp/github project:@ama-mcp/otter project:@ama-mfe/messages project:@ama-mfe/ng-utils project:@ama-sdk/client-angular project:@ama-sdk/client-beacon project:@ama-sdk/client-fetch project:@ama-sdk/core project:@ama-sdk/create project:@ama-sdk/schematics project:@ama-sdk/swagger-builder project:@ama-styling/figma-extractor project:@ama-styling/figma-sdk project:@ama-styling/style-dictionary project:@ama-styling/stylelint-plugin project:@ama-terasu/cli project:@ama-terasu/core project:@ama-terasu/schematics project:audit-gh-action project:get-npm-tag-gh-action project:new-version-gh-action project:@o3r/amaterasu-api-spec project:@o3r/amaterasu-dodo project:@o3r/amaterasu-otter project:@o3r/amaterasu-sdk project:@o3r/analytics project:@o3r/apis-manager project:@o3r/application project:@o3r/artifactory-tools project:@o3r/azure-tools project:@o3r/build-helpers project:@o3r/chrome-devtools project:@o3r/components project:@o3r/configuration project:@o3r/core project:@o3r/create project:@o3r/design project:@o3r/dynamic-content project:@o3r/eslint-config project:@o3r/eslint-plugin project:@o3r/extractors project:@o3r/forms project:@o3r/github-cascading-app project:@o3r/localization project:@o3r/logger project:@o3r/mcp project:@o3r/mobile project:@o3r/new-version project:@o3r/palette-generator project:@o3r/pipeline project:@o3r/routing project:@o3r/rules-engine project:@o3r/schematics project:@o3r/showcase project:@o3r/store-sync project:@o3r/style-dictionary project:@o3r/stylelint-plugin project:@o3r/styling project:@o3r/telemetry project:@o3r/test-helpers project:@o3r/testing project:@o3r/third-party project:@o3r/workspace project:@o3r/workspace-helpers project:@o3r-training/showcase-sdk project:@o3r-training/training-sdk project:@o3r-training/training-tools project:otter-devtools project:release-gh-action project:yarn-errors-reporter-gh-action runAllTests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants