Skip to content

Conversation

@alexei-led
Copy link
Contributor

Hi, guys

This is just a proposal: use Docker multistage build

This will enable to:

  • get a portable and repeatable build and test environment
  • build the project on any machine without a need to install and configure Go SDK (need Docker only)
  • easy switch to any CI (use even DockerHub automated build)

just one command to build docker build (or make container)

@codecov-io
Copy link

codecov-io commented Oct 23, 2017

Codecov Report

Merging #24 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #24   +/-   ##
======================================
  Coverage    23.4%   23.4%           
======================================
  Files           8       8           
  Lines         833     833           
======================================
  Hits          195     195           
  Misses        623     623           
  Partials       15      15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0f1b6b...1af5fba. Read the comment docs.

@sdminonne
Copy link
Contributor

Thanks for your contribution and your time on this.

Believe me @alexei-led I see the value, just docker on my laptop is too old (even on updated fedora).
Mind build the multistage in a docker or wait few weeks (to me to rework this, or simply moving to next fedora beta)?

.dockerignore Outdated

# ignore vendor tests
vendor/*/*/test
vendor/*/*/*/test No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add endline

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@alexei-led
Copy link
Contributor Author

@sdminonne whenever you are ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants