Skip to content

Conversation

@Arishamays1
Copy link

@Arishamays1 Arishamays1 commented Oct 7, 2022

Update for 3.7.13 with CVE Patch

Jira ticket

  • added mailcap CVE patch. The patch is the merge commit from this PR, which was the one that was accepted to fix the issue
  • made amendments to build.sh for linux-ppc64le optimization

@Arishamays1 Arishamays1 self-assigned this Oct 7, 2022
@pseudoyim pseudoyim closed this Oct 13, 2022
@pseudoyim pseudoyim reopened this Oct 13, 2022
@varlackc varlackc self-requested a review October 16, 2022 04:44
Copy link

@varlackc varlackc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a redirect on the dev_url to the following URL:

https://devguide.python.org/

Copy link

@danpetry danpetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - two minor nits but good to go

folder: externals/bzip2-1.0.8 # [win]
sha256: 12c17d15f99e27235529574a722fb484a4e8fdf2427cef53b1b68bdf07e404a9 # [win]
- url: https://github.com/python/cpython-source-deps/archive/zlib-1.2.11.zip # [win]
- url: https://github.com/python/cpython-source-deps/archive/zlib-1.2.11.zip # [win]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- url: https://github.com/python/cpython-source-deps/archive/zlib-1.2.11.zip # [win]
- url: https://github.com/python/cpython-source-deps/archive/zlib-1.2.11.zip # [win]

Very pedantic whitespace change, just to clean up the diff for this PR :)

- openssl
- readline # [not win]
- tk # [not win]
- tk # [not win]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- tk # [not win]
- tk # [not win]

likewise

@danpetry danpetry closed this Oct 17, 2022
@danpetry danpetry reopened this Oct 17, 2022
@skupr-anaconda
Copy link

The patch seems to be fine.

@Arishamays1 Arishamays1 reopened this Oct 17, 2022
@danpetry
Copy link

Prefect seems to be unstable, both win-64 and linux-64 I have seen passing before.

@Arishamays1 Arishamays1 merged commit 26fb18a into master-3.7 Oct 18, 2022
@pseudoyim pseudoyim deleted the update_3.7.13 branch November 2, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants