Open
Conversation
"webkit android 4.4.2 broken" actually searchable and local files viewable.
…hings to address this: - Implement a new folder picker that handles browsing available folders. Much of the code is borrowed from the already existing BookmarksFragment - Add rename and move operations for folders and bookmarks - Expose creating folders in the BookmarksActivity and the new folder picker (even if they're not top level!) - Clean up a lot of how TintBrowser was performing sql queries. It was concatenating the strings manually instead of trying to use the ? notation wherever possible. - Add getting the folder stack for a given folder ID. This allows the folder picker to easily jump to the current bookmark/folder's location when the user wants to move it. - Drawables, since there weren't any for adding folders nor smaller ones for the folder picker UI
Why? The content resolver takes care of the escaping for us. Not to mention, leaving it like that adds way too many duplicate history entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the nested folder support to the user. This does quite a few things to address this:
is borrowed from the already existing BookmarksFragment
level!)
instead of trying to use the ? notation wherever possible.
the current bookmark/folder's location when the user wants to move it.
Also, um, durp? I put this on a branch that dangles off right after I did the bookmarklet support.