Skip to content

Fix Hyperlink not being localized when it has content already #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndrewKeepCoding merged 1 commit into from
Jan 31, 2023
Merged

Fix Hyperlink not being localized when it has content already #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions WinUI3Localizer/LocalizationActions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using Microsoft.UI.Xaml;
using Microsoft.UI.Xaml;
using Microsoft.UI.Xaml.Documents;
using System;
using System.Collections.Generic;
Expand Down Expand Up @@ -30,15 +30,15 @@ public record ActionItem(Type TargetType, Action<ActionArguments> Action);
}),
new ActionItem(typeof(Bold), arguments =>
{
if (arguments.DependencyObject is Hyperlink target && target.Inlines.Count is 0)
if (arguments.DependencyObject is Hyperlink target)
{
target.Inlines.Clear();
target.Inlines.Add(new Run() { Text = arguments.Value });
}
}),
new ActionItem(typeof(Hyperlink), arguments =>
{
if (arguments.DependencyObject is Hyperlink target && target.Inlines.Count is 0)
if (arguments.DependencyObject is Hyperlink target)
{
target.Inlines.Clear();
target.Inlines.Add(new Run() { Text = arguments.Value });
Expand Down
6 changes: 6 additions & 0 deletions WinUI3Localizer/WinUI3Localizer.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
<Product>WinUI3Localizer</Product>
<Copyright>Copyright (c) Andrew KeepCoding 2023</Copyright>
<Authors>Andrew KeepCoding</Authors>
<PackageReadMeFile>README.md</PackageReadMeFile>
</PropertyGroup>

<ItemGroup>
Expand All @@ -37,7 +38,12 @@
<PackageReference Include="Microsoft.Windows.SDK.BuildTools" Version="10.0.22621.755" />
</ItemGroup>

<ItemGroup>
<None Include="..\README.md" Pack="true" PackagePath="\" />
</ItemGroup>

<ItemGroup>
<InternalsVisibleTo Include="$(AssemblyName).Tests" />
</ItemGroup>

</Project>