Fixes no newline before nested ReservedTopLevel tokens.#1
Open
ruffin-- wants to merge 1 commit intoAndrewWhitaker:masterfrom
Open
Fixes no newline before nested ReservedTopLevel tokens.#1ruffin-- wants to merge 1 commit intoAndrewWhitaker:masterfrom
ruffin-- wants to merge 1 commit intoAndrewWhitaker:masterfrom
Conversation
Line 232 was `Trim`ming too much. See original: https://github.com/jdorn/sql-formatter/blob/master/lib/SqlFormatter.php#L634 `$return = rtrim($return,$tab).str_repeat($tab, $indent_level);` Only need to trim tab characters from the end of `result` that `SqlFormatter` had already inserted. This was `TrimEnd`ing away any and all whitespace, including newline from previous addition.
ruffin--
pushed a commit
to ruffin--/SqlProfilerQueryCleaner
that referenced
this pull request
Aug 1, 2014
SQL parser is from the following project (MIT licensed): https://github.com/AndrewWhitaker/sql-formatter Note that the dll uploaded with this commit was run against a pull request I've submitted to that project, which fixes a small porting bug with top level tokens and newline formatting: AndrewWhitaker/sql-formatter#1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Line 232 was
Trimming too much. See original:https://github.com/jdorn/sql-formatter/blob/master/lib/SqlFormatter.php#L634
$return = rtrim($return,$tab).str_repeat($tab, $indent_level);Only need to trim tab characters from the end of
resultthatSqlFormatterhad already inserted.This was
TrimEnding away any and all whitespace, including newline from previous addition.