Skip to content

Metric screws as alternative to User defined#41

Open
pleite wants to merge 3 commits intoAndyLevesque:mainfrom
pleite:oG-screws-with-threading
Open

Metric screws as alternative to User defined#41
pleite wants to merge 3 commits intoAndyLevesque:mainfrom
pleite:oG-screws-with-threading

Conversation

@pleite
Copy link
Collaborator

@pleite pleite commented Apr 26, 2025

This is an implementation of screw_hole instead of the current user defined holes, this enforces threading to be tested on the mounting points for openGrid.

@pleite pleite marked this pull request as ready for review April 26, 2025 13:50
Co-authored-by: ejwill <jwill.will@gmail.com>
@pleite pleite requested a review from AndyLevesque April 26, 2025 17:29
@AndyLevesque
Copy link
Owner

It appears that several of the head options are not compatible. They either clip into the tile or sink the majority of the way into the lite tile. Should we remove the head options for now and retain just the screw names?

Also, should we change 'None' to 'Custom' to communicate how the manual dimensions kick in?

image
image

@ejwill
Copy link

ejwill commented Apr 28, 2025

@AndyLevesque, depending on the head style larger diameter screws will clip the board or not. If you chose a larger screw then have head type as none it will be fine. So what do we want to do about that? We could use an assert to allow combos that "work". I am working on a PR that simplifies some of this and adds back custom options.

If the screw option/name is none the board has screw holes, is that right? Seems like if someone selects none there should be no screw holes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants