Skip to content

Conversation

@umpirsky
Copy link
Contributor

@umpirsky umpirsky commented Jan 9, 2018

It's eye catcher, we don't need it if 0 notifications.

screenshot from 2018-01-09 12-21-58

It's eye catcher, we don't need it if 0 notifications.
@umpirsky
Copy link
Contributor Author

umpirsky commented Jan 9, 2018

I didn't test this, not sure if works. Please give it a try @AngelFQC.

@AngelFQC
Copy link
Owner

Hi! Thanks for PR
But the badge value is assigned before your changes, in line 25:
https://github.com/AngelFQC/firefox-github-notifier/blob/master/background.js#L25

@AngelFQC AngelFQC closed this Jan 12, 2018
@umpirsky umpirsky deleted the patch-1 branch January 12, 2018 09:13
@umpirsky
Copy link
Contributor Author

@AngelFQC Thanks, fixed in #2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants